Differential D10885

refactor: Remove nMyStartingHeight from CNode/Connman
ClosedPublic
Actions

Authored by Fabien on Jan 25 2022, 11:05.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC21ae0d505ab8: refactor: Remove nMyStartingHeight from CNode/Connman

Summary

CNode and CConnman keep track of the active chain height when CNodes have been created, but apart from serializing the int once (when sending a version message), it is unused. So it can simply be removed in favor of a single int in PeerMan that can do the same.

Backport of core#20649.

Depends on D10884.

Ref T1696.

Test Plan

ninja all check-all
ninja bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 25 2022, 11:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2022, 11:05

Fabien requested review of this revision.Jan 25 2022, 11:05

teamcity edited the summary of this revision. (Show Details)Jan 25 2022, 11:06

Harbormaster completed remote builds in B17995: Diff 31938.Jan 25 2022, 11:10

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[333/510] Building CXX object src/CMakeFiles/util.dir/util/message.cpp.o
[334/510] Building CXX object src/CMakeFiles/util.dir/util/settings.cpp.o
[335/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[336/510] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[337/510] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[338/510] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[339/510] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[340/510] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[341/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[342/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[343/510] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[344/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[345/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[346/510] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[347/510] Linking CXX static library src/libutil.a
[348/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[349/510] Linking CXX static library src/librpcclient.a
[350/510] Linking CXX static library src/libbitcoinconsensus.a
[351/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[352/510] Linking CXX static library src/libscript.a
[353/510] Linking CXX static library src/libcommon.a
[354/510] Linking CXX shared library src/libbitcoinconsensus.so.0.24.10
[355/510] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[356/510] Linking CXX executable src/bitcoin-cli
[357/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[358/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[359/510] Linking CXX executable src/bitcoin-tx
[360/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[361/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[362/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[363/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[364/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[365/510] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[366/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[367/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[368/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[369/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[370/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[371/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[372/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqutil.cpp.o
[373/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[374/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[375/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[376/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[377/510] Linking CXX static library src/zmq/libzmq.a
[378/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[379/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[380/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[381/510] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[382/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[383/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[384/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[385/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[386/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[387/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[388/510] Linking CXX static library src/wallet/libwallet.a
[389/510] Linking CXX static library src/wallet/libwallet-tool.a
[390/510] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

PiRK requested changes to this revision.Jan 25 2022, 12:07

PiRK added a subscriber: PiRK.

PiRK added inline comments.