[net processing] Move addr relay data and logic into net processing
ClosedPublic
Actions

Authored by PiRK on Jan 28 2022, 12:46.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb694185bf69a: [net processing] Move addr relay data and logic into net processing

Summary

This is a backport of core#21186 [3/5]
https://github.com/bitcoin/bitcoin/pull/21186/commits/76568a3351418c878d30ba0373cf76988f93f90e

Depends on D10928

Test Plan

ninja all check-all
ninja bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr21186

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18053
Build 35928: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-debug · build-clang-tidy · build-clang
Build 35927: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 28 2022, 12:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2022, 12:46

teamcity edited the summary of this revision. (Show Details)Jan 28 2022, 12:46

rebase

Fabien added a subscriber: Fabien.Jan 28 2022, 13:05

Fabien added inline comments.

src/net_processing.cpp
5718	You reverted the logic

Harbormaster completed remote builds in B18053: Diff 32046.Jan 28 2022, 13:07

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc-cmdline.py ======

------- Stdout: -------
2022-01-28T13:05:29.048000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/abc-cmdline_8
2022-01-28T13:05:29.836000Z TestFramework (INFO): Testing -maxaddrtosend=10
2022-01-28T13:06:34.170000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:06:34.171000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/abc-cmdline.py", line 121, in run_test
    self.maxaddrtosend_test(max_addr_to_send)
  File "/work/test/functional/abc-cmdline.py", line 66, in maxaddrtosend_test
    peer.wait_until(peer.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:06:34.221000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:06:36.529000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/abc-cmdline_8
2022-01-28T13:06:36.529000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/abc-cmdline_8/test_framework.log
2022-01-28T13:06:36.529000Z TestFramework (ERROR): 
2022-01-28T13:06:36.529000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/abc-cmdline_8' to consolidate all logs
2022-01-28T13:06:36.529000Z TestFramework (ERROR): 
2022-01-28T13:06:36.529000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:06:36.529000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:06:36.529000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_addr_relay.py ======

------- Stdout: -------
2022-01-28T13:05:59.876000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_addr_relay_48
2022-01-28T13:06:00.176000Z TestFramework (INFO): Send an addr message that is too large
2022-01-28T13:06:00.405000Z TestFramework (INFO): Test address relay
2022-01-28T13:06:00.405000Z TestFramework (INFO): Check that addr message content is relayed and added to addrman
2022-01-28T13:06:01.978000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addr_relay.py", line 58, in run_test
    self.relay_tests()
  File "/work/test/functional/p2p_addr_relay.py", line 129, in relay_tests
    ipv4_branching_factor)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(0 == 20)
2022-01-28T13:06:02.031000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:06:06.694000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_addr_relay_48
2022-01-28T13:06:06.694000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_addr_relay_48/test_framework.log
2022-01-28T13:06:06.694000Z TestFramework (ERROR): 
2022-01-28T13:06:06.694000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_addr_relay_48' to consolidate all logs
2022-01-28T13:06:06.694000Z TestFramework (ERROR): 
2022-01-28T13:06:06.694000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:06:06.694000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:06:06.694000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_addrv2_relay.py ======

------- Stdout: -------
2022-01-28T13:06:02.873000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_addrv2_relay_49
2022-01-28T13:06:03.130000Z TestFramework (INFO): Create connection that sends addrv2 messages
2022-01-28T13:06:03.230000Z TestFramework (INFO): Send too-large addrv2 message
2022-01-28T13:06:03.284000Z TestFramework (INFO): Check that addrv2 message content is relayed and added to addrman
2022-01-28T13:07:03.466000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:07:03.466000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addrv2_relay.py", line 69, in run_test
    addr_receiver.wait_for_addrv2()
  File "/work/test/functional/p2p_addrv2_relay.py", line 40, in wait_for_addrv2
    self.wait_until(lambda: "addrv2" in self.last_message)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:07:03.518000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:07:03.820000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_addrv2_relay_49
2022-01-28T13:07:03.820000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_addrv2_relay_49/test_framework.log
2022-01-28T13:07:03.820000Z TestFramework (ERROR): 
2022-01-28T13:07:03.820000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_addrv2_relay_49' to consolidate all logs
2022-01-28T13:07:03.820000Z TestFramework (ERROR): 
2022-01-28T13:07:03.820000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:07:03.820000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:07:03.820000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_getaddr_caching.py ======

------- Stdout: -------
2022-01-28T13:06:04.204000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_getaddr_caching_50
2022-01-28T13:06:04.492000Z TestFramework (INFO): Fill peer AddrMan with a lot of records
2022-01-28T13:06:08.123000Z TestFramework (INFO): Send many addr requests within short time to receive
2022-01-28T13:07:08.293000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:07:08.293000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_getaddr_caching.py", line 67, in run_test
    addr_receiver.wait_until(addr_receiver.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:07:08.344000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:07:11.808000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_getaddr_caching_50
2022-01-28T13:07:11.808000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_getaddr_caching_50/test_framework.log
2022-01-28T13:07:11.809000Z TestFramework (ERROR): 
2022-01-28T13:07:11.809000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_getaddr_caching_50' to consolidate all logs
2022-01-28T13:07:11.809000Z TestFramework (ERROR): 
2022-01-28T13:07:11.809000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:07:11.809000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:07:11.809000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_node_network_limited.py ======

------- Stdout: -------
2022-01-28T13:05:50.044000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_node_network_limited_34
2022-01-28T13:05:50.407000Z TestFramework (INFO): Check that node has signalled expected services.
2022-01-28T13:05:50.407000Z TestFramework (INFO): Check that the localservices is as expected.
2022-01-28T13:05:50.407000Z TestFramework (INFO): Mine enough blocks to reach the NODE_NETWORK_LIMITED range.
2022-01-28T13:05:51.631000Z TestFramework (INFO): Make sure we can max retrieve block at tip-288.
2022-01-28T13:05:51.682000Z TestFramework (INFO): Requesting block at height 2 (tip-289) must fail (ignored).
2022-01-28T13:05:51.782000Z TestFramework (INFO): Check local address relay, do a fresh connection.
2022-01-28T13:05:56.897000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:05:56.897000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_node_network_limited.py", line 94, in run_test
    node1.wait_for_addr()
  File "/work/test/functional/p2p_node_network_limited.py", line 36, in wait_for_addr
    self.wait_until(test_function, timeout=timeout)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 5.0 seconds
2022-01-28T13:05:56.948000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:05:57.150000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_node_network_limited_34
2022-01-28T13:05:57.150000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_node_network_limited_34/test_framework.log
2022-01-28T13:05:57.150000Z TestFramework (ERROR): 
2022-01-28T13:05:57.150000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_130452/p2p_node_network_limited_34' to consolidate all logs
2022-01-28T13:05:57.150000Z TestFramework (ERROR): 
2022-01-28T13:05:57.150000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:05:57.150000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:05:57.150000Z TestFramework (ERROR):

fix reversed logic

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc-cmdline.py ======

------- Stdout: -------
2022-01-28T13:06:54.753000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/abc-cmdline_8
2022-01-28T13:06:56.087000Z TestFramework (INFO): Testing -maxaddrtosend=10
2022-01-28T13:08:02.662000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:08:02.662000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/abc-cmdline.py", line 121, in run_test
    self.maxaddrtosend_test(max_addr_to_send)
  File "/work/test/functional/abc-cmdline.py", line 66, in maxaddrtosend_test
    peer.wait_until(peer.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:08:02.713000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:08:07.673000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/abc-cmdline_8
2022-01-28T13:08:07.673000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/abc-cmdline_8/test_framework.log
2022-01-28T13:08:07.673000Z TestFramework (ERROR): 
2022-01-28T13:08:07.673000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/abc-cmdline_8' to consolidate all logs
2022-01-28T13:08:07.673000Z TestFramework (ERROR): 
2022-01-28T13:08:07.673000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:08:07.673000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:08:07.673000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_addr_relay.py ======

------- Stdout: -------
2022-01-28T13:09:37.150000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_addr_relay_48
2022-01-28T13:09:37.775000Z TestFramework (INFO): Send an addr message that is too large
2022-01-28T13:09:37.931000Z TestFramework (INFO): Test address relay
2022-01-28T13:09:37.931000Z TestFramework (INFO): Check that addr message content is relayed and added to addrman
2022-01-28T13:09:39.491000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addr_relay.py", line 58, in run_test
    self.relay_tests()
  File "/work/test/functional/p2p_addr_relay.py", line 129, in relay_tests
    ipv4_branching_factor)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(0 == 20)
2022-01-28T13:09:39.541000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:09:44.302000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_addr_relay_48
2022-01-28T13:09:44.302000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_addr_relay_48/test_framework.log
2022-01-28T13:09:44.302000Z TestFramework (ERROR): 
2022-01-28T13:09:44.302000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_addr_relay_48' to consolidate all logs
2022-01-28T13:09:44.302000Z TestFramework (ERROR): 
2022-01-28T13:09:44.302000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:09:44.302000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:09:44.302000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_addrv2_relay.py ======

------- Stdout: -------
2022-01-28T13:09:37.276000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_addrv2_relay_49
2022-01-28T13:09:37.831000Z TestFramework (INFO): Create connection that sends addrv2 messages
2022-01-28T13:09:37.932000Z TestFramework (INFO): Send too-large addrv2 message
2022-01-28T13:09:37.986000Z TestFramework (INFO): Check that addrv2 message content is relayed and added to addrman
2022-01-28T13:10:38.184000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:10:38.184000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addrv2_relay.py", line 69, in run_test
    addr_receiver.wait_for_addrv2()
  File "/work/test/functional/p2p_addrv2_relay.py", line 40, in wait_for_addrv2
    self.wait_until(lambda: "addrv2" in self.last_message)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:10:38.237000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:10:39.541000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_addrv2_relay_49
2022-01-28T13:10:39.541000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_addrv2_relay_49/test_framework.log
2022-01-28T13:10:39.541000Z TestFramework (ERROR): 
2022-01-28T13:10:39.541000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_addrv2_relay_49' to consolidate all logs
2022-01-28T13:10:39.541000Z TestFramework (ERROR): 
2022-01-28T13:10:39.541000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:10:39.541000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:10:39.541000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_getaddr_caching.py ======

------- Stdout: -------
2022-01-28T13:09:40.998000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_getaddr_caching_50
2022-01-28T13:09:41.581000Z TestFramework (INFO): Fill peer AddrMan with a lot of records
2022-01-28T13:09:47.914000Z TestFramework (INFO): Send many addr requests within short time to receive
2022-01-28T13:10:48.093000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:10:48.093000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_getaddr_caching.py", line 67, in run_test
    addr_receiver.wait_until(addr_receiver.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:10:48.144000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:10:53.154000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_getaddr_caching_50
2022-01-28T13:10:53.154000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_getaddr_caching_50/test_framework.log
2022-01-28T13:10:53.154000Z TestFramework (ERROR): 
2022-01-28T13:10:53.154000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_getaddr_caching_50' to consolidate all logs
2022-01-28T13:10:53.154000Z TestFramework (ERROR): 
2022-01-28T13:10:53.154000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:10:53.154000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:10:53.154000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_node_network_limited.py ======

------- Stdout: -------
2022-01-28T13:08:53.570000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_node_network_limited_34
2022-01-28T13:08:54.182000Z TestFramework (INFO): Check that node has signalled expected services.
2022-01-28T13:08:54.182000Z TestFramework (INFO): Check that the localservices is as expected.
2022-01-28T13:08:54.184000Z TestFramework (INFO): Mine enough blocks to reach the NODE_NETWORK_LIMITED range.
2022-01-28T13:08:56.018000Z TestFramework (INFO): Make sure we can max retrieve block at tip-288.
2022-01-28T13:08:56.068000Z TestFramework (INFO): Requesting block at height 2 (tip-289) must fail (ignored).
2022-01-28T13:08:56.169000Z TestFramework (INFO): Check local address relay, do a fresh connection.
2022-01-28T13:09:01.284000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:09:01.284000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_node_network_limited.py", line 94, in run_test
    node1.wait_for_addr()
  File "/work/test/functional/p2p_node_network_limited.py", line 36, in wait_for_addr
    self.wait_until(test_function, timeout=timeout)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 5.0 seconds
2022-01-28T13:09:01.334000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:09:01.537000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_node_network_limited_34
2022-01-28T13:09:01.537000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_node_network_limited_34/test_framework.log
2022-01-28T13:09:01.537000Z TestFramework (ERROR): 
2022-01-28T13:09:01.538000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_130555/p2p_node_network_limited_34' to consolidate all logs
2022-01-28T13:09:01.538000Z TestFramework (ERROR): 
2022-01-28T13:09:01.538000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:09:01.538000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:09:01.538000Z TestFramework (ERROR):

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc-cmdline.py ======

------- Stdout: -------
2022-01-28T13:08:22.984000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/abc-cmdline_8
2022-01-28T13:08:31.002000Z TestFramework (INFO): Testing -maxaddrtosend=10
2022-01-28T13:09:35.521000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:09:35.521000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/abc-cmdline.py", line 121, in run_test
    self.maxaddrtosend_test(max_addr_to_send)
  File "/work/test/functional/abc-cmdline.py", line 66, in maxaddrtosend_test
    peer.wait_until(peer.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:09:35.574000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:09:37.083000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/abc-cmdline_8
2022-01-28T13:09:37.084000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/abc-cmdline_8/test_framework.log
2022-01-28T13:09:37.084000Z TestFramework (ERROR): 
2022-01-28T13:09:37.084000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/abc-cmdline_8' to consolidate all logs
2022-01-28T13:09:37.084000Z TestFramework (ERROR): 
2022-01-28T13:09:37.084000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:09:37.084000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:09:37.084000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_addr_relay.py ======

------- Stdout: -------
2022-01-28T13:10:25.938000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_addr_relay_48
2022-01-28T13:10:26.256000Z TestFramework (INFO): Send an addr message that is too large
2022-01-28T13:10:26.462000Z TestFramework (INFO): Test address relay
2022-01-28T13:10:26.462000Z TestFramework (INFO): Check that addr message content is relayed and added to addrman
2022-01-28T13:10:28.021000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addr_relay.py", line 58, in run_test
    self.relay_tests()
  File "/work/test/functional/p2p_addr_relay.py", line 129, in relay_tests
    ipv4_branching_factor)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(0 == 20)
2022-01-28T13:10:28.072000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:10:32.933000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_addr_relay_48
2022-01-28T13:10:32.933000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_addr_relay_48/test_framework.log
2022-01-28T13:10:32.933000Z TestFramework (ERROR): 
2022-01-28T13:10:32.933000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_addr_relay_48' to consolidate all logs
2022-01-28T13:10:32.933000Z TestFramework (ERROR): 
2022-01-28T13:10:32.933000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:10:32.933000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:10:32.933000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_addrv2_relay.py ======

------- Stdout: -------
2022-01-28T13:10:28.595000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_addrv2_relay_49
2022-01-28T13:10:28.912000Z TestFramework (INFO): Create connection that sends addrv2 messages
2022-01-28T13:10:29.014000Z TestFramework (INFO): Send too-large addrv2 message
2022-01-28T13:10:29.081000Z TestFramework (INFO): Check that addrv2 message content is relayed and added to addrman
2022-01-28T13:11:29.250000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:11:29.250000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addrv2_relay.py", line 69, in run_test
    addr_receiver.wait_for_addrv2()
  File "/work/test/functional/p2p_addrv2_relay.py", line 40, in wait_for_addrv2
    self.wait_until(lambda: "addrv2" in self.last_message)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:11:29.302000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:11:29.554000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_addrv2_relay_49
2022-01-28T13:11:29.555000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_addrv2_relay_49/test_framework.log
2022-01-28T13:11:29.555000Z TestFramework (ERROR): 
2022-01-28T13:11:29.555000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_addrv2_relay_49' to consolidate all logs
2022-01-28T13:11:29.555000Z TestFramework (ERROR): 
2022-01-28T13:11:29.555000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:11:29.555000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:11:29.555000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_getaddr_caching.py ======

------- Stdout: -------
2022-01-28T13:10:29.365000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_getaddr_caching_50
2022-01-28T13:10:29.692000Z TestFramework (INFO): Fill peer AddrMan with a lot of records
2022-01-28T13:10:33.113000Z TestFramework (INFO): Send many addr requests within short time to receive
2022-01-28T13:11:33.272000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:11:33.272000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_getaddr_caching.py", line 67, in run_test
    addr_receiver.wait_until(addr_receiver.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:11:33.323000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:11:35.628000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_getaddr_caching_50
2022-01-28T13:11:35.628000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_getaddr_caching_50/test_framework.log
2022-01-28T13:11:35.628000Z TestFramework (ERROR): 
2022-01-28T13:11:35.628000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_getaddr_caching_50' to consolidate all logs
2022-01-28T13:11:35.628000Z TestFramework (ERROR): 
2022-01-28T13:11:35.628000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:11:35.628000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:11:35.628000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_node_network_limited.py ======

------- Stdout: -------
2022-01-28T13:09:58.100000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_node_network_limited_34
2022-01-28T13:09:58.460000Z TestFramework (INFO): Check that node has signalled expected services.
2022-01-28T13:09:58.460000Z TestFramework (INFO): Check that the localservices is as expected.
2022-01-28T13:09:58.461000Z TestFramework (INFO): Mine enough blocks to reach the NODE_NETWORK_LIMITED range.
2022-01-28T13:09:59.665000Z TestFramework (INFO): Make sure we can max retrieve block at tip-288.
2022-01-28T13:09:59.716000Z TestFramework (INFO): Requesting block at height 2 (tip-289) must fail (ignored).
2022-01-28T13:09:59.816000Z TestFramework (INFO): Check local address relay, do a fresh connection.
2022-01-28T13:10:04.946000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:10:04.947000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_node_network_limited.py", line 94, in run_test
    node1.wait_for_addr()
  File "/work/test/functional/p2p_node_network_limited.py", line 36, in wait_for_addr
    self.wait_until(test_function, timeout=timeout)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 5.0 seconds
2022-01-28T13:10:04.999000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:10:05.209000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_node_network_limited_34
2022-01-28T13:10:05.209000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_node_network_limited_34/test_framework.log
2022-01-28T13:10:05.209000Z TestFramework (ERROR): 
2022-01-28T13:10:05.210000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_130746/p2p_node_network_limited_34' to consolidate all logs
2022-01-28T13:10:05.210000Z TestFramework (ERROR): 
2022-01-28T13:10:05.210000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:10:05.211000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:10:05.211000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc-cmdline.py ======

------- Stdout: -------
2022-01-28T13:12:54.415000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/abc-cmdline_8
2022-01-28T13:12:55.366000Z TestFramework (INFO): Testing -maxaddrtosend=10
2022-01-28T13:13:59.354000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:13:59.354000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/abc-cmdline.py", line 121, in run_test
    self.maxaddrtosend_test(max_addr_to_send)
  File "/work/test/functional/abc-cmdline.py", line 66, in maxaddrtosend_test
    peer.wait_until(peer.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:13:59.405000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:14:02.113000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/abc-cmdline_8
2022-01-28T13:14:02.113000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/abc-cmdline_8/test_framework.log
2022-01-28T13:14:02.113000Z TestFramework (ERROR): 
2022-01-28T13:14:02.114000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/abc-cmdline_8' to consolidate all logs
2022-01-28T13:14:02.114000Z TestFramework (ERROR): 
2022-01-28T13:14:02.114000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:14:02.114000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:14:02.114000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: p2p_addr_relay.py ======

------- Stdout: -------
2022-01-28T13:14:43.435000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_addr_relay_48
2022-01-28T13:14:43.779000Z TestFramework (INFO): Send an addr message that is too large
2022-01-28T13:14:44.000000Z TestFramework (INFO): Test address relay
2022-01-28T13:14:44.001000Z TestFramework (INFO): Check that addr message content is relayed and added to addrman
2022-01-28T13:14:45.568000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addr_relay.py", line 58, in run_test
    self.relay_tests()
  File "/work/test/functional/p2p_addr_relay.py", line 129, in relay_tests
    ipv4_branching_factor)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(0 == 20)
2022-01-28T13:14:45.618000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:14:50.178000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_addr_relay_48
2022-01-28T13:14:50.178000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_addr_relay_48/test_framework.log
2022-01-28T13:14:50.178000Z TestFramework (ERROR): 
2022-01-28T13:14:50.178000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_addr_relay_48' to consolidate all logs
2022-01-28T13:14:50.178000Z TestFramework (ERROR): 
2022-01-28T13:14:50.178000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:14:50.178000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:14:50.178000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: p2p_addrv2_relay.py ======

------- Stdout: -------
2022-01-28T13:14:45.784000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_addrv2_relay_49
2022-01-28T13:14:46.062000Z TestFramework (INFO): Create connection that sends addrv2 messages
2022-01-28T13:14:46.163000Z TestFramework (INFO): Send too-large addrv2 message
2022-01-28T13:14:46.216000Z TestFramework (INFO): Check that addrv2 message content is relayed and added to addrman
2022-01-28T13:15:46.413000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:15:46.413000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addrv2_relay.py", line 69, in run_test
    addr_receiver.wait_for_addrv2()
  File "/work/test/functional/p2p_addrv2_relay.py", line 40, in wait_for_addrv2
    self.wait_until(lambda: "addrv2" in self.last_message)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:15:46.464000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:15:46.615000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_addrv2_relay_49
2022-01-28T13:15:46.616000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_addrv2_relay_49/test_framework.log
2022-01-28T13:15:46.616000Z TestFramework (ERROR): 
2022-01-28T13:15:46.616000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_addrv2_relay_49' to consolidate all logs
2022-01-28T13:15:46.616000Z TestFramework (ERROR): 
2022-01-28T13:15:46.616000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:15:46.616000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:15:46.616000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: p2p_getaddr_caching.py ======

------- Stdout: -------
2022-01-28T13:14:47.279000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_getaddr_caching_50
2022-01-28T13:14:47.586000Z TestFramework (INFO): Fill peer AddrMan with a lot of records
2022-01-28T13:14:51.291000Z TestFramework (INFO): Send many addr requests within short time to receive
2022-01-28T13:15:51.504000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:15:51.505000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_getaddr_caching.py", line 67, in run_test
    addr_receiver.wait_until(addr_receiver.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:15:51.557000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:15:53.613000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_getaddr_caching_50
2022-01-28T13:15:53.613000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_getaddr_caching_50/test_framework.log
2022-01-28T13:15:53.614000Z TestFramework (ERROR): 
2022-01-28T13:15:53.614000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_getaddr_caching_50' to consolidate all logs
2022-01-28T13:15:53.614000Z TestFramework (ERROR): 
2022-01-28T13:15:53.614000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:15:53.614000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:15:53.615000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: p2p_node_network_limited.py ======

------- Stdout: -------
2022-01-28T13:14:21.248000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_node_network_limited_34
2022-01-28T13:14:21.609000Z TestFramework (INFO): Check that node has signalled expected services.
2022-01-28T13:14:21.609000Z TestFramework (INFO): Check that the localservices is as expected.
2022-01-28T13:14:21.610000Z TestFramework (INFO): Mine enough blocks to reach the NODE_NETWORK_LIMITED range.
2022-01-28T13:14:22.827000Z TestFramework (INFO): Make sure we can max retrieve block at tip-288.
2022-01-28T13:14:22.877000Z TestFramework (INFO): Requesting block at height 2 (tip-289) must fail (ignored).
2022-01-28T13:14:22.978000Z TestFramework (INFO): Check local address relay, do a fresh connection.
2022-01-28T13:14:28.091000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:14:28.092000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_node_network_limited.py", line 94, in run_test
    node1.wait_for_addr()
  File "/work/test/functional/p2p_node_network_limited.py", line 36, in wait_for_addr
    self.wait_until(test_function, timeout=timeout)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 5.0 seconds
2022-01-28T13:14:28.142000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:14:28.294000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_node_network_limited_34
2022-01-28T13:14:28.295000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_node_network_limited_34/test_framework.log
2022-01-28T13:14:28.295000Z TestFramework (ERROR): 
2022-01-28T13:14:28.295000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_131214/p2p_node_network_limited_34' to consolidate all logs
2022-01-28T13:14:28.295000Z TestFramework (ERROR): 
2022-01-28T13:14:28.295000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:14:28.295000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:14:28.295000Z TestFramework (ERROR):

PiRK published this revision for review.Jan 28 2022, 13:23

PiRK added a child revision: D10930: scripted-diff: rename address relay fields.Jan 28 2022, 13:23

PiRK edited the test plan for this revision. (Show Details)Jan 28 2022, 13:25

Harbormaster completed remote builds in B18056: Diff 32049.Jan 28 2022, 13:29

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc-cmdline.py ======

------- Stdout: -------
2022-01-28T13:25:58.189000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/abc-cmdline_8
2022-01-28T13:25:58.995000Z TestFramework (INFO): Testing -maxaddrtosend=10
2022-01-28T13:27:03.212000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:27:03.213000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/abc-cmdline.py", line 121, in run_test
    self.maxaddrtosend_test(max_addr_to_send)
  File "/work/test/functional/abc-cmdline.py", line 66, in maxaddrtosend_test
    peer.wait_until(peer.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:27:03.263000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:27:05.825000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/abc-cmdline_8
2022-01-28T13:27:05.825000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/abc-cmdline_8/test_framework.log
2022-01-28T13:27:05.825000Z TestFramework (ERROR): 
2022-01-28T13:27:05.826000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/abc-cmdline_8' to consolidate all logs
2022-01-28T13:27:05.826000Z TestFramework (ERROR): 
2022-01-28T13:27:05.826000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:27:05.826000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:27:05.826000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_addr_relay.py ======

------- Stdout: -------
2022-01-28T13:26:41.563000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_addr_relay_48
2022-01-28T13:26:41.835000Z TestFramework (INFO): Send an addr message that is too large
2022-01-28T13:26:42.041000Z TestFramework (INFO): Test address relay
2022-01-28T13:26:42.041000Z TestFramework (INFO): Check that addr message content is relayed and added to addrman
2022-01-28T13:26:43.598000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addr_relay.py", line 58, in run_test
    self.relay_tests()
  File "/work/test/functional/p2p_addr_relay.py", line 129, in relay_tests
    ipv4_branching_factor)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(0 == 20)
2022-01-28T13:26:43.649000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:26:48.407000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_addr_relay_48
2022-01-28T13:26:48.407000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_addr_relay_48/test_framework.log
2022-01-28T13:26:48.407000Z TestFramework (ERROR): 
2022-01-28T13:26:48.407000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_addr_relay_48' to consolidate all logs
2022-01-28T13:26:48.407000Z TestFramework (ERROR): 
2022-01-28T13:26:48.407000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:26:48.408000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:26:48.408000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_addrv2_relay.py ======

------- Stdout: -------
2022-01-28T13:26:43.095000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_addrv2_relay_49
2022-01-28T13:26:43.351000Z TestFramework (INFO): Create connection that sends addrv2 messages
2022-01-28T13:26:43.452000Z TestFramework (INFO): Send too-large addrv2 message
2022-01-28T13:26:43.505000Z TestFramework (INFO): Check that addrv2 message content is relayed and added to addrman
2022-01-28T13:27:43.671000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:27:43.671000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addrv2_relay.py", line 69, in run_test
    addr_receiver.wait_for_addrv2()
  File "/work/test/functional/p2p_addrv2_relay.py", line 40, in wait_for_addrv2
    self.wait_until(lambda: "addrv2" in self.last_message)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:27:43.723000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:27:44.075000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_addrv2_relay_49
2022-01-28T13:27:44.075000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_addrv2_relay_49/test_framework.log
2022-01-28T13:27:44.075000Z TestFramework (ERROR): 
2022-01-28T13:27:44.075000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_addrv2_relay_49' to consolidate all logs
2022-01-28T13:27:44.075000Z TestFramework (ERROR): 
2022-01-28T13:27:44.075000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:27:44.075000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:27:44.075000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_getaddr_caching.py ======

------- Stdout: -------
2022-01-28T13:26:45.175000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_getaddr_caching_50
2022-01-28T13:26:45.447000Z TestFramework (INFO): Fill peer AddrMan with a lot of records
2022-01-28T13:26:49.115000Z TestFramework (INFO): Send many addr requests within short time to receive
2022-01-28T13:27:49.289000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:27:49.289000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_getaddr_caching.py", line 67, in run_test
    addr_receiver.wait_until(addr_receiver.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:27:49.340000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:27:52.909000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_getaddr_caching_50
2022-01-28T13:27:52.909000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_getaddr_caching_50/test_framework.log
2022-01-28T13:27:52.909000Z TestFramework (ERROR): 
2022-01-28T13:27:52.909000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_getaddr_caching_50' to consolidate all logs
2022-01-28T13:27:52.909000Z TestFramework (ERROR): 
2022-01-28T13:27:52.909000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:27:52.909000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:27:52.909000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_node_network_limited.py ======

------- Stdout: -------
2022-01-28T13:26:27.378000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_node_network_limited_34
2022-01-28T13:26:27.738000Z TestFramework (INFO): Check that node has signalled expected services.
2022-01-28T13:26:27.738000Z TestFramework (INFO): Check that the localservices is as expected.
2022-01-28T13:26:27.739000Z TestFramework (INFO): Mine enough blocks to reach the NODE_NETWORK_LIMITED range.
2022-01-28T13:26:28.932000Z TestFramework (INFO): Make sure we can max retrieve block at tip-288.
2022-01-28T13:26:28.982000Z TestFramework (INFO): Requesting block at height 2 (tip-289) must fail (ignored).
2022-01-28T13:26:29.083000Z TestFramework (INFO): Check local address relay, do a fresh connection.
2022-01-28T13:26:34.196000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:26:34.196000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_node_network_limited.py", line 94, in run_test
    node1.wait_for_addr()
  File "/work/test/functional/p2p_node_network_limited.py", line 36, in wait_for_addr
    self.wait_until(test_function, timeout=timeout)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 5.0 seconds
2022-01-28T13:26:34.247000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:26:34.449000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_node_network_limited_34
2022-01-28T13:26:34.449000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_node_network_limited_34/test_framework.log
2022-01-28T13:26:34.449000Z TestFramework (ERROR): 
2022-01-28T13:26:34.450000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220128_132523/p2p_node_network_limited_34' to consolidate all logs
2022-01-28T13:26:34.450000Z TestFramework (ERROR): 
2022-01-28T13:26:34.450000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:26:34.450000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:26:34.450000Z TestFramework (ERROR):

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc-cmdline.py ======

------- Stdout: -------
2022-01-28T13:24:26.584000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/abc-cmdline_8
2022-01-28T13:24:28.430000Z TestFramework (INFO): Testing -maxaddrtosend=10
2022-01-28T13:25:38.102000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:25:38.102000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/abc-cmdline.py", line 121, in run_test
    self.maxaddrtosend_test(max_addr_to_send)
  File "/work/test/functional/abc-cmdline.py", line 66, in maxaddrtosend_test
    peer.wait_until(peer.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:25:38.153000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:25:40.509000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/abc-cmdline_8
2022-01-28T13:25:40.509000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/abc-cmdline_8/test_framework.log
2022-01-28T13:25:40.509000Z TestFramework (ERROR): 
2022-01-28T13:25:40.509000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/abc-cmdline_8' to consolidate all logs
2022-01-28T13:25:40.509000Z TestFramework (ERROR): 
2022-01-28T13:25:40.509000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:25:40.509000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:25:40.509000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_addr_relay.py ======

------- Stdout: -------
2022-01-28T13:27:03.866000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_addr_relay_48
2022-01-28T13:27:04.444000Z TestFramework (INFO): Send an addr message that is too large
2022-01-28T13:27:04.600000Z TestFramework (INFO): Test address relay
2022-01-28T13:27:04.600000Z TestFramework (INFO): Check that addr message content is relayed and added to addrman
2022-01-28T13:27:06.158000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addr_relay.py", line 58, in run_test
    self.relay_tests()
  File "/work/test/functional/p2p_addr_relay.py", line 129, in relay_tests
    ipv4_branching_factor)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(0 == 20)
2022-01-28T13:27:06.209000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:27:11.069000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_addr_relay_48
2022-01-28T13:27:11.069000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_addr_relay_48/test_framework.log
2022-01-28T13:27:11.069000Z TestFramework (ERROR): 
2022-01-28T13:27:11.069000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_addr_relay_48' to consolidate all logs
2022-01-28T13:27:11.069000Z TestFramework (ERROR): 
2022-01-28T13:27:11.069000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:27:11.069000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:27:11.069000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_addrv2_relay.py ======

------- Stdout: -------
2022-01-28T13:27:10.204000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_addrv2_relay_49
2022-01-28T13:27:10.767000Z TestFramework (INFO): Create connection that sends addrv2 messages
2022-01-28T13:27:10.867000Z TestFramework (INFO): Send too-large addrv2 message
2022-01-28T13:27:10.921000Z TestFramework (INFO): Check that addrv2 message content is relayed and added to addrman
2022-01-28T13:28:11.097000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:28:11.097000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addrv2_relay.py", line 69, in run_test
    addr_receiver.wait_for_addrv2()
  File "/work/test/functional/p2p_addrv2_relay.py", line 40, in wait_for_addrv2
    self.wait_until(lambda: "addrv2" in self.last_message)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:28:11.148000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:28:12.101000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_addrv2_relay_49
2022-01-28T13:28:12.101000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_addrv2_relay_49/test_framework.log
2022-01-28T13:28:12.101000Z TestFramework (ERROR): 
2022-01-28T13:28:12.101000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_addrv2_relay_49' to consolidate all logs
2022-01-28T13:28:12.101000Z TestFramework (ERROR): 
2022-01-28T13:28:12.101000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:28:12.101000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:28:12.101000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_getaddr_caching.py ======

------- Stdout: -------
2022-01-28T13:27:10.474000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_getaddr_caching_50
2022-01-28T13:27:11.301000Z TestFramework (INFO): Fill peer AddrMan with a lot of records
2022-01-28T13:27:18.212000Z TestFramework (INFO): Send many addr requests within short time to receive
2022-01-28T13:28:18.390000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:28:18.390000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_getaddr_caching.py", line 67, in run_test
    addr_receiver.wait_until(addr_receiver.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:28:18.441000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:28:23.251000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_getaddr_caching_50
2022-01-28T13:28:23.251000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_getaddr_caching_50/test_framework.log
2022-01-28T13:28:23.251000Z TestFramework (ERROR): 
2022-01-28T13:28:23.251000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_getaddr_caching_50' to consolidate all logs
2022-01-28T13:28:23.251000Z TestFramework (ERROR): 
2022-01-28T13:28:23.251000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:28:23.251000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:28:23.251000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_node_network_limited.py ======

------- Stdout: -------
2022-01-28T13:26:24.724000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_node_network_limited_34
2022-01-28T13:26:25.337000Z TestFramework (INFO): Check that node has signalled expected services.
2022-01-28T13:26:25.337000Z TestFramework (INFO): Check that the localservices is as expected.
2022-01-28T13:26:25.338000Z TestFramework (INFO): Mine enough blocks to reach the NODE_NETWORK_LIMITED range.
2022-01-28T13:26:27.173000Z TestFramework (INFO): Make sure we can max retrieve block at tip-288.
2022-01-28T13:26:27.223000Z TestFramework (INFO): Requesting block at height 2 (tip-289) must fail (ignored).
2022-01-28T13:26:27.324000Z TestFramework (INFO): Check local address relay, do a fresh connection.
2022-01-28T13:26:32.439000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:26:32.439000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_node_network_limited.py", line 94, in run_test
    node1.wait_for_addr()
  File "/work/test/functional/p2p_node_network_limited.py", line 36, in wait_for_addr
    self.wait_until(test_function, timeout=timeout)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 5.0 seconds
2022-01-28T13:26:32.490000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:26:32.743000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_node_network_limited_34
2022-01-28T13:26:32.743000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_node_network_limited_34/test_framework.log
2022-01-28T13:26:32.743000Z TestFramework (ERROR): 
2022-01-28T13:26:32.743000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220128_132339/p2p_node_network_limited_34' to consolidate all logs
2022-01-28T13:26:32.743000Z TestFramework (ERROR): 
2022-01-28T13:26:32.743000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:26:32.743000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:26:32.743000Z TestFramework (ERROR):

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc-cmdline.py ======

------- Stdout: -------
2022-01-28T13:24:02.984000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/abc-cmdline_8
2022-01-28T13:24:03.791000Z TestFramework (INFO): Testing -maxaddrtosend=10
2022-01-28T13:25:09.110000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:25:09.111000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/abc-cmdline.py", line 121, in run_test
    self.maxaddrtosend_test(max_addr_to_send)
  File "/work/test/functional/abc-cmdline.py", line 66, in maxaddrtosend_test
    peer.wait_until(peer.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:25:09.163000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:25:09.869000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/abc-cmdline_8
2022-01-28T13:25:09.869000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/abc-cmdline_8/test_framework.log
2022-01-28T13:25:09.869000Z TestFramework (ERROR): 
2022-01-28T13:25:09.870000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/abc-cmdline_8' to consolidate all logs
2022-01-28T13:25:09.870000Z TestFramework (ERROR): 
2022-01-28T13:25:09.870000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:25:09.870000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:25:09.870000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_addr_relay.py ======

------- Stdout: -------
2022-01-28T13:25:52.940000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_addr_relay_48
2022-01-28T13:25:53.305000Z TestFramework (INFO): Send an addr message that is too large
2022-01-28T13:25:53.522000Z TestFramework (INFO): Test address relay
2022-01-28T13:25:53.522000Z TestFramework (INFO): Check that addr message content is relayed and added to addrman
2022-01-28T13:25:55.094000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addr_relay.py", line 58, in run_test
    self.relay_tests()
  File "/work/test/functional/p2p_addr_relay.py", line 129, in relay_tests
    ipv4_branching_factor)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(0 == 20)
2022-01-28T13:25:55.147000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:25:59.761000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_addr_relay_48
2022-01-28T13:25:59.761000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_addr_relay_48/test_framework.log
2022-01-28T13:25:59.761000Z TestFramework (ERROR): 
2022-01-28T13:25:59.761000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_addr_relay_48' to consolidate all logs
2022-01-28T13:25:59.761000Z TestFramework (ERROR): 
2022-01-28T13:25:59.761000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:25:59.761000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:25:59.761000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_addrv2_relay.py ======

------- Stdout: -------
2022-01-28T13:25:57.119000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_addrv2_relay_49
2022-01-28T13:25:57.407000Z TestFramework (INFO): Create connection that sends addrv2 messages
2022-01-28T13:25:57.508000Z TestFramework (INFO): Send too-large addrv2 message
2022-01-28T13:25:57.562000Z TestFramework (INFO): Check that addrv2 message content is relayed and added to addrman
2022-01-28T13:26:57.766000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:26:57.766000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addrv2_relay.py", line 69, in run_test
    addr_receiver.wait_for_addrv2()
  File "/work/test/functional/p2p_addrv2_relay.py", line 40, in wait_for_addrv2
    self.wait_until(lambda: "addrv2" in self.last_message)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:26:57.817000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:26:58.018000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_addrv2_relay_49
2022-01-28T13:26:58.019000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_addrv2_relay_49/test_framework.log
2022-01-28T13:26:58.019000Z TestFramework (ERROR): 
2022-01-28T13:26:58.019000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_addrv2_relay_49' to consolidate all logs
2022-01-28T13:26:58.019000Z TestFramework (ERROR): 
2022-01-28T13:26:58.019000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:26:58.019000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:26:58.019000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_getaddr_caching.py ======

------- Stdout: -------
2022-01-28T13:25:58.873000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_getaddr_caching_50
2022-01-28T13:25:59.193000Z TestFramework (INFO): Fill peer AddrMan with a lot of records
2022-01-28T13:26:03.178000Z TestFramework (INFO): Send many addr requests within short time to receive
2022-01-28T13:27:03.396000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:27:03.396000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_getaddr_caching.py", line 67, in run_test
    addr_receiver.wait_until(addr_receiver.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:27:03.449000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:27:05.156000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_getaddr_caching_50
2022-01-28T13:27:05.156000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_getaddr_caching_50/test_framework.log
2022-01-28T13:27:05.156000Z TestFramework (ERROR): 
2022-01-28T13:27:05.156000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_getaddr_caching_50' to consolidate all logs
2022-01-28T13:27:05.156000Z TestFramework (ERROR): 
2022-01-28T13:27:05.156000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:27:05.157000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:27:05.157000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: p2p_node_network_limited.py ======

------- Stdout: -------
2022-01-28T13:25:30.854000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_node_network_limited_34
2022-01-28T13:25:31.215000Z TestFramework (INFO): Check that node has signalled expected services.
2022-01-28T13:25:31.215000Z TestFramework (INFO): Check that the localservices is as expected.
2022-01-28T13:25:31.215000Z TestFramework (INFO): Mine enough blocks to reach the NODE_NETWORK_LIMITED range.
2022-01-28T13:25:32.430000Z TestFramework (INFO): Make sure we can max retrieve block at tip-288.
2022-01-28T13:25:32.481000Z TestFramework (INFO): Requesting block at height 2 (tip-289) must fail (ignored).
2022-01-28T13:25:32.581000Z TestFramework (INFO): Check local address relay, do a fresh connection.
2022-01-28T13:25:37.698000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:25:37.698000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_node_network_limited.py", line 94, in run_test
    node1.wait_for_addr()
  File "/work/test/functional/p2p_node_network_limited.py", line 36, in wait_for_addr
    self.wait_until(test_function, timeout=timeout)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 5.0 seconds
2022-01-28T13:25:37.749000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:25:37.952000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_node_network_limited_34
2022-01-28T13:25:37.952000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_node_network_limited_34/test_framework.log
2022-01-28T13:25:37.952000Z TestFramework (ERROR): 
2022-01-28T13:25:37.952000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132326/p2p_node_network_limited_34' to consolidate all logs
2022-01-28T13:25:37.952000Z TestFramework (ERROR): 
2022-01-28T13:25:37.952000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:25:37.952000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:25:37.952000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc-cmdline.py ======

------- Stdout: -------
2022-01-28T13:28:16.573000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/abc-cmdline_8
2022-01-28T13:28:17.506000Z TestFramework (INFO): Testing -maxaddrtosend=10
2022-01-28T13:29:21.498000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:29:21.499000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/abc-cmdline.py", line 121, in run_test
    self.maxaddrtosend_test(max_addr_to_send)
  File "/work/test/functional/abc-cmdline.py", line 66, in maxaddrtosend_test
    peer.wait_until(peer.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:29:21.551000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:29:23.510000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/abc-cmdline_8
2022-01-28T13:29:23.510000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/abc-cmdline_8/test_framework.log
2022-01-28T13:29:23.510000Z TestFramework (ERROR): 
2022-01-28T13:29:23.510000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/abc-cmdline_8' to consolidate all logs
2022-01-28T13:29:23.510000Z TestFramework (ERROR): 
2022-01-28T13:29:23.510000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:29:23.510000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:29:23.510000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: p2p_addr_relay.py ======

------- Stdout: -------
2022-01-28T13:30:09.166000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_addr_relay_48
2022-01-28T13:30:09.534000Z TestFramework (INFO): Send an addr message that is too large
2022-01-28T13:30:09.764000Z TestFramework (INFO): Test address relay
2022-01-28T13:30:09.764000Z TestFramework (INFO): Check that addr message content is relayed and added to addrman
2022-01-28T13:30:11.332000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addr_relay.py", line 58, in run_test
    self.relay_tests()
  File "/work/test/functional/p2p_addr_relay.py", line 129, in relay_tests
    ipv4_branching_factor)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(0 == 20)
2022-01-28T13:30:11.385000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:30:16.097000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_addr_relay_48
2022-01-28T13:30:16.097000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_addr_relay_48/test_framework.log
2022-01-28T13:30:16.097000Z TestFramework (ERROR): 
2022-01-28T13:30:16.097000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_addr_relay_48' to consolidate all logs
2022-01-28T13:30:16.097000Z TestFramework (ERROR): 
2022-01-28T13:30:16.097000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:30:16.098000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:30:16.098000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: p2p_addrv2_relay.py ======

------- Stdout: -------
2022-01-28T13:30:11.015000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_addrv2_relay_49
2022-01-28T13:30:11.309000Z TestFramework (INFO): Create connection that sends addrv2 messages
2022-01-28T13:30:11.411000Z TestFramework (INFO): Send too-large addrv2 message
2022-01-28T13:30:11.481000Z TestFramework (INFO): Check that addrv2 message content is relayed and added to addrman
2022-01-28T13:31:11.683000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:31:11.683000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_addrv2_relay.py", line 69, in run_test
    addr_receiver.wait_for_addrv2()
  File "/work/test/functional/p2p_addrv2_relay.py", line 40, in wait_for_addrv2
    self.wait_until(lambda: "addrv2" in self.last_message)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:31:11.734000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:31:11.886000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_addrv2_relay_49
2022-01-28T13:31:11.886000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_addrv2_relay_49/test_framework.log
2022-01-28T13:31:11.886000Z TestFramework (ERROR): 
2022-01-28T13:31:11.886000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_addrv2_relay_49' to consolidate all logs
2022-01-28T13:31:11.886000Z TestFramework (ERROR): 
2022-01-28T13:31:11.886000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:31:11.886000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:31:11.886000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: p2p_getaddr_caching.py ======

------- Stdout: -------
2022-01-28T13:30:12.019000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_getaddr_caching_50
2022-01-28T13:30:12.316000Z TestFramework (INFO): Fill peer AddrMan with a lot of records
2022-01-28T13:30:16.028000Z TestFramework (INFO): Send many addr requests within short time to receive
2022-01-28T13:31:16.228000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:31:16.228000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_getaddr_caching.py", line 67, in run_test
    addr_receiver.wait_until(addr_receiver.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-28T13:31:16.279000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:31:19.136000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_getaddr_caching_50
2022-01-28T13:31:19.136000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_getaddr_caching_50/test_framework.log
2022-01-28T13:31:19.136000Z TestFramework (ERROR): 
2022-01-28T13:31:19.136000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_getaddr_caching_50' to consolidate all logs
2022-01-28T13:31:19.136000Z TestFramework (ERROR): 
2022-01-28T13:31:19.136000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:31:19.136000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:31:19.136000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: p2p_node_network_limited.py ======

------- Stdout: -------
2022-01-28T13:29:41.778000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_node_network_limited_34
2022-01-28T13:29:42.138000Z TestFramework (INFO): Check that node has signalled expected services.
2022-01-28T13:29:42.139000Z TestFramework (INFO): Check that the localservices is as expected.
2022-01-28T13:29:42.139000Z TestFramework (INFO): Mine enough blocks to reach the NODE_NETWORK_LIMITED range.
2022-01-28T13:29:43.338000Z TestFramework (INFO): Make sure we can max retrieve block at tip-288.
2022-01-28T13:29:43.389000Z TestFramework (INFO): Requesting block at height 2 (tip-289) must fail (ignored).
2022-01-28T13:29:43.489000Z TestFramework (INFO): Check local address relay, do a fresh connection.
2022-01-28T13:29:48.604000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-28T13:29:48.604000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/p2p_node_network_limited.py", line 94, in run_test
    node1.wait_for_addr()
  File "/work/test/functional/p2p_node_network_limited.py", line 36, in wait_for_addr
    self.wait_until(test_function, timeout=timeout)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 5.0 seconds
2022-01-28T13:29:48.654000Z TestFramework (INFO): Stopping nodes
2022-01-28T13:29:48.858000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_node_network_limited_34
2022-01-28T13:29:48.858000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_node_network_limited_34/test_framework.log
2022-01-28T13:29:48.858000Z TestFramework (ERROR): 
2022-01-28T13:29:48.859000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220128_132739/p2p_node_network_limited_34' to consolidate all logs
2022-01-28T13:29:48.859000Z TestFramework (ERROR): 
2022-01-28T13:29:48.859000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-28T13:29:48.859000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-28T13:29:48.860000Z TestFramework (ERROR):