Page MenuHomePhabricator

[p2p] Small follow-ups to 21528
ClosedPublic

Authored by Fabien on Jan 28 2022, 15:22.

Details

Reviewers
tyler-smith
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
T1693: Add more foreign currencies
Commits
rABCe4ef397e3c6c: [p2p] Small follow-ups to 21528
Summary

Backport of core#22618.

Depends on D10933.

Ref T1693.

Test Plan
ninja all check-all

Event Timeline

Fabien requested review of this revision.Jan 28 2022, 15:22
tyler-smith added a subscriber: tyler-smith.
tyler-smith added inline comments.
doc/release-notes.md
11 ↗(On Diff #32061)

I've never seen the worked "romour" used this way. It appears to be used like "gossip" but you use gossip later so maybe there's a difference I'm not getting?

I don't see it in the codebase so if it's a synonym I think it'd be better to stick with "gossip", and if it's not we should maybe define it somewhere.

This revision now requires changes to proceed.Jan 28 2022, 17:34

Consistently use "gossip" instead of "rumour". I don't have a good enough understanding of the difference in usage between these 2 words in english to prefer one over the other.
Also remove the PR number which is irrelevant in our release notes.

These additions and typo-fix look good.

This revision is now accepted and ready to land.Feb 1 2022, 14:49
This revision was automatically updated to reflect the committed changes.