Page MenuHomePhabricator
Differential D1110

Add UTXO commitment contruction from UTXO cursor
AbandonedPublic
Actions

Authored by tomtomtom7 on Feb 16 2018, 15:29.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

This is used for initial upgrade. The first version is still sequential.

We may also want to use this for (pre-fast-sync) Initial Load. As this
means we will need to only add 50 million UTXOs instead of 1.2 billion.

Depends on D1074

Test Plan

Test included

Diff Detail

Repository
rABC Bitcoin ABC
Branch
utxo1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1880
Build 1920: Bitcoin ABC Buildbot (legacy)
Build 1919: arc lint + arc unit

Event Timeline

tomtomtom7 created this revision.Feb 16 2018, 15:29
Owners added a reviewer: Restricted Owners Package.Feb 16 2018, 15:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 16 2018, 15:29
teamcity added a subscriber: teamcity.Feb 16 2018, 15:31

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B1880: Diff 2904.Feb 16 2018, 15:50
teamcity added a comment.Feb 16 2018, 15:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

tomtomtom7 added a child revision: D1117: Integrate UtxoCommitment in CCoinView.Feb 22 2018, 11:53
tomtomtom7 updated this revision to Diff 3010.Feb 28 2018, 15:59

Change the combine constructor to an Add method.

This is more consistent with the way it is used.

teamcity added a comment.Feb 28 2018, 16:01

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 28 2018, 16:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1951: Diff 3010.Feb 28 2018, 16:23
tomtomtom7 abandoned this revision.Mar 6 2018, 14:09

This is no integrated in D1074

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 6 2018, 14:09
matiu added a subscriber: matiu.Jun 12 2018, 17:54
matiu added inline comments.
src/test/utxocommit_tests.cpp
157 ↗(On Diff #3010)

Dead code for the current count = 50000;

tomtomtom7 added inline comments.Jun 14 2018, 12:51
src/test/utxocommit_tests.cpp
157 ↗(On Diff #3010)

This diff is abandoned.

Revision Contents
Changeset List

PathSize
src/
test/
1 line
49 lines
4 lines
32 lines

Diff 2904

View Options

src/test/test_bitcoin.h

Loading...
View Options

src/test/utxocommit_tests.cpp

Loading...
View Options

src/utxocommit.h

Loading...
View Options

src/utxocommit.cpp

Loading...