Paths

Table of Contentst

Differential D11136

test: refactor: remove hex_str_to_bytes helper
ClosedPublic
Actions

Authored by PiRK on Mar 7 2022, 09:36.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf19bc27b6096: test: refactor: remove hex_str_to_bytes helper

Summary

Use the built-in class method bytes.fromhex() instead, which is available since Python 3.0.

This is a backport of core#22593

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 7 2022, 09:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 7 2022, 09:36

PiRK requested review of this revision.Mar 7 2022, 09:36

teamcity edited the summary of this revision. (Show Details)Mar 7 2022, 09:37

PiRK added a child revision: D11138: test: refactor: remove unneeded bytes<->hex conversions in `byte_to_base58`.Mar 7 2022, 09:42

Fabien accepted this revision.Mar 7 2022, 09:48

This revision is now accepted and ready to land.Mar 7 2022, 09:48

Harbormaster completed remote builds in B18418: Diff 32613.Mar 7 2022, 09:52

Closed by commit rABCf19bc27b6096: test: refactor: remove hex_str_to_bytes helper (authored by PiRK). · Explain WhyMar 7 2022, 12:39

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf19bc27b6096: test: refactor: remove hex_str_to_bytes helper.

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_dbcrash.py

4 lines

feature_notifications.py

4 lines

interface_rest.py

3 lines

p2p_invalid_messages.py

8 lines

rpc_decodescript.py

10 lines

rpc_rawtransaction.py

7 lines

test_framework/

8 lines

4 lines

9 lines

4 lines

7 lines

wallet_import_with_label.py

3 lines

Diff 32618

View Options

test/functional/feature_dbcrash.py

View Options

test/functional/feature_notifications.py

View Options

test/functional/interface_rest.py

View Options

test/functional/p2p_invalid_messages.py

View Options

test/functional/rpc_decodescript.py

View Options

test/functional/rpc_rawtransaction.py

View Options

test/functional/test_framework/address.py

View Options

test/functional/test_framework/messages.py

View Options

test/functional/test_framework/util.py

View Options

test/functional/test_framework/wallet.py

View Options

test/functional/test_framework/wallet_util.py

View Options

test/functional/wallet_import_with_label.py

test: refactor: remove hex_str_to_bytes helperClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32618

test/functional/feature_dbcrash.py

test/functional/feature_notifications.py

test/functional/interface_rest.py

test/functional/p2p_invalid_messages.py

test/functional/rpc_decodescript.py

test/functional/rpc_rawtransaction.py

test/functional/test_framework/address.py

test/functional/test_framework/messages.py

test/functional/test_framework/util.py

test/functional/test_framework/wallet.py

test/functional/test_framework/wallet_util.py

test/functional/wallet_import_with_label.py

test: refactor: remove hex_str_to_bytes helper
ClosedPublic
Actions

Revision Contents
Changeset List