Page MenuHomePhabricator

test: refactor: remove unneeded bytes<->hex conversions in `byte_to_base58`
ClosedPublic

Authored by PiRK on Mar 7 2022, 09:42.

Details

Summary

It seems like the only reason for using hex strings in this method was to have a convenient way to convert to an integer from the input data interpreted as big-endian.
In Python3 we have int.from_bytes(..., 'big') for that purpose, hence there is no need for that anymore and we can simply operate on bytes only.

This is a backport of core#24324

Depends on D11136

Test Plan

ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable