Page MenuHomePhabricator

rpc: Add hash_type MUHASH to gettxoutsetinfo and add a test
ClosedPublic

Authored by PiRK on Mar 11 2022, 09:21.

Event Timeline

PiRK requested review of this revision.Mar 11 2022, 09:21
Fabien requested changes to this revision.Mar 11 2022, 13:30
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/node/coinstats.cpp
46 ↗(On Diff #32661)

This method would benefit from taking a TxId directly. It's probably worth a refactor as I see the other methods all take an uint256 as well, despite working on transactions

54 ↗(On Diff #32661)

Out of scope, but it would be a good idea to have a method for this and make it less opaque.

src/rpc/blockchain.cpp
1235 ↗(On Diff #32661)

Can be static

1277 ↗(On Diff #32661)

Does this deserve a release note ?

This revision now requires changes to proceed.Mar 11 2022, 13:30

rebase on D11162, add a release note, make a function static, make ApplyHash takes a txid

This revision is now accepted and ready to land.Mar 12 2022, 07:35