Page MenuHomePhabricator
Differential D1118

Use build directory for functional test junit results
ClosedPublic
Actions

Authored by deadalnix on Feb 22 2018, 23:10.

Details

Reviewers
matra774
matiu
schancel
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rSTAGING6bfe93a833ef: Use build directory for functional test junit results
rABC6bfe93a833ef: Use build directory for functional test junit results
Summary

Use build_dir for test output directory.

Test Plan

Run functional tests and see where junit_results.xml is placed.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.Feb 22 2018, 23:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2018, 23:10
teamcity added a subscriber: teamcity.Feb 22 2018, 23:11

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel updated this revision to Diff 2950.Feb 22 2018, 23:12

Use os.path.join instead of formatting

teamcity added a comment.Feb 22 2018, 23:14

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel updated this revision to Diff 2951.Feb 22 2018, 23:25

Fix autopep8 indentation issue

teamcity added a comment.Feb 22 2018, 23:29

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

teamcity added a comment.Feb 22 2018, 23:29

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster failed remote builds in B1907: Diff 2949!Feb 22 2018, 23:29
teamcity added a comment.Feb 22 2018, 23:35

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1908: Diff 2950.Feb 22 2018, 23:35
teamcity added a comment.Feb 22 2018, 23:47

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B1909: Diff 2951!Feb 22 2018, 23:47
deadalnix accepted this revision.Feb 23 2018, 13:41
This revision is now accepted and ready to land.Feb 23 2018, 13:41
teamcity added a comment.Feb 24 2018, 05:15

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 24 2018, 05:37

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1909: Diff 2951.Feb 24 2018, 05:37
deadalnix commandeered this revision.Feb 24 2018, 06:55
deadalnix edited reviewers, added: schancel; removed: deadalnix.
This revision now requires review to proceed.Feb 24 2018, 06:55
deadalnix updated this revision to Diff 2959.Feb 24 2018, 07:16

remove dependency on D1116

Harbormaster completed remote builds in B1917: Diff 2959.Feb 24 2018, 07:16
deadalnix removed a parent revision: D1116: Write test timing information to the build tree when running test_runner.py.Feb 24 2018, 07:16
deadalnix edited the summary of this revision. (Show Details)
teamcity added a comment.Feb 24 2018, 07:16

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel accepted this revision.Feb 24 2018, 07:23

lgtm

This revision is now accepted and ready to land.Feb 24 2018, 07:23
Closed by commit rABC6bfe93a833ef: Use build directory for functional test junit results (authored by deadalnix). · Explain WhyFeb 24 2018, 07:24
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Feb 24 2018, 07:35

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1917: Diff 2959.Feb 24 2018, 07:36
Fabien mentioned this in D3151: Don't use the functional test arguments in the tmp directory name.May 30 2019, 05:19

Revision Contents
Changeset List

PathSize
test/
functional/
39 lines

Diff 2960

View Options

test/functional/test_runner.py

Loading...