validation: Remove global ::VersionBitsTip{State,SinceHeight,Statistics}
ClosedPublic
Actions

Authored by PiRK on Mar 17 2022, 12:06.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC7176fb75a43a: validation: Remove global ::VersionBitsTip{State,SinceHeight,Statistics}

Summary

Tip: versionbitscache is currently a global so we didn't need to pass it in to any of ::VersionBitsTip*'s callers

Notes:

I had to restore versionbitscache in validation.h, removed in D2783.
VersionBitsBlockState was not used anywhere. It was introduced and used in D5282, then minerfund.cpp was deleted then added again but without using that function.

This is a backport of core#21055 [6/16]
https://github.com/bitcoin/bitcoin/pull/21055/commits/31eac50c721dd3b0bd2347e76196bf16913e9be9

Depends on D11210

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr21055

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18545
Build 36885: Build Diff	build-clang-tidy · build-debug · build-clang · lint-circular-dependencies · build-without-wallet · build-diff
Build 36884: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 17 2022, 12:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2022, 12:06

PiRK requested review of this revision.Mar 17 2022, 12:06

teamcity edited the summary of this revision. (Show Details)Mar 17 2022, 12:06

PiRK edited the summary of this revision. (Show Details)Mar 17 2022, 12:09

Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
Good job! The circular dependency "minerfund -> validation -> minerfund" is no longer present.
Please remove it from EXPECTED_CIRCULAR_DEPENDENCIES in /work/test/lint/lint-circular-dependencies.sh
to make sure this circular dependency is not accidentally reintroduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1

Harbormaster completed remote builds in B18544: Diff 32808.Mar 17 2022, 12:25

remove solved circular dependeny from linter

Fabien accepted this revision.Mar 17 2022, 13:33

This revision is now accepted and ready to land.Mar 17 2022, 13:33

Harbormaster completed remote builds in B18545: Diff 32809.Mar 17 2022, 13:53

Closed by commit rABC7176fb75a43a: validation: Remove global ::VersionBitsTip{State,SinceHeight,Statistics} (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMar 17 2022, 14:17

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7176fb75a43a: validation: Remove global ::VersionBitsTip{State,SinceHeight,Statistics}.