Page MenuHomePhabricator

[avalanche] Always allow for downloading our local proof if it has been advertised
ClosedPublic

Authored by Fabien on Mar 31 2022, 13:12.

Details

Reviewers
tyler-smith
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC63bcb254f37f: [avalanche] Always allow for downloading our local proof if it has been…
Summary

Our local proof can be advertised by an avahello message before it gets validated upon startup, because it is waiting for a block to proceed to the proof verification.
This can also occur during IBD, and the node will return a notfound for the proofid. This phenomenon prevents the peer from requesting it again from us and can significantly slow down the proof relaying for our node. In order to prevent this, we can simply assume our proof is valid and allow for it to be downloaded with no delay. To prevent DoS'ing it still has to be announced first.

Ref T1864.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_always_send_local_proof
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18697
Build 37185: Build Difflint-circular-dependencies · build-clang-tidy · build-without-wallet · build-diff · build-debug · build-clang
Build 37184: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Mar 31 2022, 13:12
tyler-smith added a subscriber: tyler-smith.

This makes sense. Other nodes must always validate the proofs anyways.

This revision is now accepted and ready to land.Mar 31 2022, 14:34