Page MenuHomePhabricator
Differential D1130

Allow setting nMinimumChainWork on command line
ClosedPublic
Actions

Authored by deadalnix on Feb 24 2018, 10:36.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING9dfbcf1407be: Allow setting nMinimumChainWork on command line
rABC9dfbcf1407be: Allow setting nMinimumChainWork on command line
Summary

Backport core's PR10357

Depends on D1129

Test Plan
make check
./test/functional/test_runner.py minchainwork

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Feb 24 2018, 10:36
Harbormaster completed remote builds in B1922: Diff 2968.Feb 24 2018, 10:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 24 2018, 10:36
Herald added a reviewer: Restricted Project. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 24 2018, 10:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 24 2018, 11:01

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1922: Diff 2968.Feb 24 2018, 11:01
jasonbcox requested changes to this revision.Feb 24 2018, 15:14
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
1230 ↗(On Diff #2968)

Add curly braces to here and all if statements in this function.

This revision now requires changes to proceed.Feb 24 2018, 15:14
deadalnix requested review of this revision.Feb 25 2018, 09:10
deadalnix added inline comments.
src/validation.cpp
1230 ↗(On Diff #2968)

I'd be happy to do it, but that's kind of out of the bounds of this diff, and would obfuscate the change actually made.

jasonbcox accepted this revision.Feb 25 2018, 09:25
jasonbcox added inline comments.
src/validation.cpp
1230 ↗(On Diff #2968)

Fair enough.

This revision is now accepted and ready to land.Feb 25 2018, 09:25
Closed by commit rABC9dfbcf1407be: Allow setting nMinimumChainWork on command line (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by deadalnix). · Explain WhyFeb 25 2018, 11:50
This revision was automatically updated to reflect the committed changes.
deadalnix mentioned this in D1763: [P2P] Timeout for headers sync.Sep 11 2018, 11:13
deadalnix mentioned this in rABCaf85afbd1d7a: [P2P] Timeout for headers sync.Sep 17 2018, 07:42
deadalnix mentioned this in rSTAGINGaf85afbd1d7a: [P2P] Timeout for headers sync.Sep 27 2018, 19:03

Revision Contents
Changeset List

PathSize
src/
33 lines
3 lines
test/
23 lines
8 lines
12 lines
16 lines
10 lines
test/
functional/
90 lines
1 line

Diff 2977

View Options

src/init.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/utilstrencodings.h

Loading...
View Options

src/utilstrencodings.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/minchainwork.py

Loading...
View Options

test/functional/test_runner.py

Loading...