Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCde5af9faa194: [Cashtab] Replace hardcoded length limit with settings param

Summary

Related to task T2388. Replaced hardcoded 24 character length limit in Configure.js with a parameter in the currency object.

Test Plan

cd web/cashtab && npm start
navigate to settings tab
attempt to rename a wallet with a string that is > 24 characters
error message should appear if string is too long

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kieran709 created this revision.Apr 11 2022, 16:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2022, 16:38

kieran709 requested review of this revision.Apr 11 2022, 16:38

Harbormaster completed remote builds in B18787: Diff 33158.Apr 11 2022, 16:40

bytesofman requested changes to this revision.Apr 12 2022, 09:49

bytesofman added inline comments.

web/cashtab/src/components/Common/Ticker.js
31 ↗	(On Diff #33158)	`localStorageMaxCharacters`
web/cashtab/src/components/Configure/Configure.js
483 ↗	(On Diff #33158)	Should be `<=` This is technically a bug and somewhat distinct from this diff. However, okay to solve here because before...24 was just a number....now we are being clear that 24 is the expected max char count, not 23.