Page MenuHomePhabricator

[Cashtab] Replace hardcoded length limit with settings param
ClosedPublic

Authored by kieran709 on Apr 11 2022, 16:38.

Details

Summary

Related to task T2388. Replaced hardcoded 24 character length limit in Configure.js with a parameter in the currency object.

Test Plan

cd web/cashtab && npm start
navigate to settings tab
attempt to rename a wallet with a string that is > 24 characters
error message should appear if string is too long

Diff Detail

Repository
rABC Bitcoin ABC
Branch
move-hardcoded-length-limit-to-ticker
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18787
Build 37365: Build Diffcashtab-tests
Build 37364: arc lint + arc unit

Event Timeline

bytesofman added inline comments.
web/cashtab/src/components/Common/Ticker.js
31

localStorageMaxCharacters

web/cashtab/src/components/Configure/Configure.js
483

Should be <=

This is technically a bug and somewhat distinct from this diff. However, okay to solve here because before...24 was just a number....now we are being clear that 24 is the expected max char count, not 23.

This revision now requires changes to proceed.Apr 12 2022, 09:49

responding to review feedback

Rebase to latest master and apply to the 24 used for Contact List name

This revision now requires changes to proceed.Apr 14 2022, 09:37

Responding to review feedback.

This revision is now accepted and ready to land.Apr 20 2022, 16:56