Page MenuHomePhabricator

move-only: Move *Disk functions to blockstorage
ClosedPublic

Authored by PiRK on Apr 13 2022, 13:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb46af778f1ee: move-only: Move *Disk functions to blockstorage
Summary

Can be reviewed with the git options
--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

This is a backport of core#21575 [4/6]
https://github.com/bitcoin/bitcoin/pull/21575/commits/fa0c7d9ad24d3c9515d3f9c136af4071cbd79055

Depends on D11349 and D11355

Notes:

  • we don't have the ReadRawBlockFromDisk functions, which are related to segwit
  • some functions were in blockdb.{h|cpp} rather than validation.{h|cpp} in Bitcoin ABC. blockdb.{h|cpp} will most likely be unnecessary and deleted as a result of this series of backports.
Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Apr 13 2022, 13:09

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "node/blockstorage -> validation -> txdb -> node/blockstorage" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1
PiRK planned changes to this revision.Apr 13 2022, 13:43
PiRK edited the summary of this revision. (Show Details)

rebase onto D11355 to avoid an extra circular dependency

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "node/blockstorage -> validation -> txdb -> node/blockstorage" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1
PiRK planned changes to this revision.Apr 25 2022, 13:23

remove the useless include

This revision is now accepted and ready to land.Apr 25 2022, 14:41