move-only: Move *Disk functions to blockstorage
ClosedPublic
Actions

Authored by PiRK on Apr 13 2022, 13:09.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb46af778f1ee: move-only: Move *Disk functions to blockstorage

Summary

Can be reviewed with the git options
--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

This is a backport of core#21575 [4/6]
https://github.com/bitcoin/bitcoin/pull/21575/commits/fa0c7d9ad24d3c9515d3f9c136af4071cbd79055

Depends on D11349 and D11355

Notes:

we don't have the ReadRawBlockFromDisk functions, which are related to segwit
some functions were in blockdb.{h|cpp} rather than validation.{h|cpp} in Bitcoin ABC. blockdb.{h|cpp} will most likely be unnecessary and deleted as a result of this series of backports.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18878
Build 37539: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 37538: arc lint + arc unit

Event Timeline

PiRK created this revision.Apr 13 2022, 13:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2022, 13:09

PiRK requested review of this revision.Apr 13 2022, 13:09

teamcity edited the summary of this revision. (Show Details)Apr 13 2022, 13:09

PiRK added a child revision: D11351: blockstorage: [refactor] Use chainman reference where possible.Apr 13 2022, 13:11

Harbormaster completed remote builds in B18814: Diff 33203.Apr 13 2022, 13:23

Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "node/blockstorage -> validation -> txdb -> node/blockstorage" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1

PiRK planned changes to this revision.Apr 13 2022, 13:43

PiRK mentioned this in D11355: retire support of pre-0.22.8 block index upgrade.Apr 25 2022, 07:22

rebase onto D11355 to avoid an extra circular dependency

Harbormaster completed remote builds in B18874: Diff 33296.Apr 25 2022, 09:14

Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "node/blockstorage -> validation -> txdb -> node/blockstorage" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1

PiRK planned changes to this revision.Apr 25 2022, 13:23

remove the useless include

Harbormaster completed remote builds in B18878: Diff 33300.Apr 25 2022, 14:10

Fabien accepted this revision.Apr 25 2022, 14:41

This revision is now accepted and ready to land.Apr 25 2022, 14:41

Closed by commit rABCb46af778f1ee: move-only: Move *Disk functions to blockstorage (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyApr 27 2022, 10:18

This revision was automatically updated to reflect the committed changes.

PiRK mentioned this in rABC1b7645404f4b: retire support of pre-0.22.8 block index upgrade.

PiRK added a commit: rABCb46af778f1ee: move-only: Move *Disk functions to blockstorage.

PiRK mentioned this in D12032: refactor: Move pruning/reindex/importing globals to blockstorage.Sep 22 2022, 16:33

PiRK mentioned this in rABC8b08cc0ac8f3: refactor: Move pruning/reindex/importing globals to blockstorage.Sep 23 2022, 06:24