Page MenuHomePhabricator

[avalanche] Improve logging of the vote status update
ClosedPublic

Authored by Fabien on May 5 2022, 09:43.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC79c038dfd007: [avalanche] Improve logging of the vote status update
Summary

This makes the log message consistent between blocks and proofs.

Test Plan
ninja check-functional-extended

Run a quorum of bitcoind nodes and look at the log

Diff Detail

Event Timeline

Fabien requested review of this revision.May 5 2022, 09:43
PiRK added inline comments.
src/net_processing.cpp
5147 ↗(On Diff #33395)

Is it OK in C++17 to use auto for function parameters?
Here it says C++20 https://en.cppreference.com/w/cpp/language/function_template#Abbreviated_function_template

This revision is now accepted and ready to land.May 5 2022, 15:15
src/net_processing.cpp
5147 ↗(On Diff #33395)

This is a generic lambda, a C++14 feature:
https://en.cppreference.com/w/cpp/language/lambda

Rebase to remove the dependency