node/ifaces: NodeImpl: Use existing NodeContext member
ClosedPublic
Actions

Authored by PiRK on May 5 2022, 16:29.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC01a7dd7dc3f0: node/ifaces: NodeImpl: Use existing NodeContext member

Summary

This is a backport of core#21270 [8/12] and core#21525 [9/10]
https://github.com/bitcoin/bitcoin/pull/21270/commits/8a1d580b2156268e3ab30f902b3fc9aa87bd2819
https://github.com/bitcoin/bitcoin/pull/21525/commits/98c4e252f0d09bebb2e4ad3289407459c2cda5d5

Depends on D11423

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18958
Build 37681: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 37680: arc lint + arc unit

Event Timeline

PiRK created this revision.May 5 2022, 16:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2022, 16:29

PiRK requested review of this revision.May 5 2022, 16:29

teamcity edited the summary of this revision. (Show Details)May 5 2022, 16:29

PiRK edited the summary of this revision. (Show Details)May 5 2022, 16:29

PiRK added a parent revision: D11423: node: Use existing NodeContext.

PiRK added a child revision: D11425: node/ifaces: ChainImpl: Use existing NodeContext member.May 5 2022, 16:33

Harbormaster completed remote builds in B18958: Diff 33411.May 5 2022, 16:53

Fabien accepted this revision.May 6 2022, 09:52

This revision is now accepted and ready to land.May 6 2022, 09:52

Closed by commit rABC01a7dd7dc3f0: node/ifaces: NodeImpl: Use existing NodeContext member (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMay 9 2022, 06:54

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC01a7dd7dc3f0: node/ifaces: NodeImpl: Use existing NodeContext member.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

node.cpp

46 lines

Diff 33411

View Options

node/ifaces: NodeImpl: Use existing NodeContext memberClosedPublicActions