Page MenuHomePhabricator
Differential D11485

txorphanage: Extract HaveOrphanTx
ClosedPublic
Actions

Authored by PiRK on May 18 2022, 08:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4c724a272e9f: txorphanage: Extract HaveOrphanTx
Summary

Extract some common code into HaveOrphanTx function.

This is a backport of core#21148 [5/14]
https://github.com/bitcoin/bitcoin/pull/21148/commits/83679ffc600305ec0926fd195ee31c11de2ed613

Depends on D11484

Test Plan

With clang and debug:
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 18 2022, 08:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2022, 08:08
PiRK requested review of this revision.May 18 2022, 08:08
teamcity edited the summary of this revision. (Show Details)May 18 2022, 08:08
Harbormaster completed remote builds in B19074: Diff 33576.May 18 2022, 08:26
PiRK added a child revision: D11486: txorphanage: Extract GetOrphanTx.May 18 2022, 08:30
Fabien requested changes to this revision.May 18 2022, 14:48
Fabien added a subscriber: Fabien.

You need clang thread safety and debug build in your test plan

This revision now requires changes to proceed.May 18 2022, 14:48
PiRK updated this revision to Diff 33583.May 18 2022, 15:02
PiRK edited the test plan for this revision. (Show Details)

added clang and debug to the test plan

Fabien accepted this revision.May 18 2022, 15:05
This revision is now accepted and ready to land.May 18 2022, 15:05
Harbormaster completed remote builds in B19081: Diff 33583.May 18 2022, 15:17
PiRK updated this revision to Diff 33598.May 19 2022, 07:58

rebase

Harbormaster completed remote builds in B19095: Diff 33598.May 19 2022, 08:15
Closed by commit rABC4c724a272e9f: txorphanage: Extract HaveOrphanTx (authored by PiRK). · Explain WhyMay 19 2022, 16:07
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4c724a272e9f: txorphanage: Extract HaveOrphanTx.

Revision Contents
Changeset List

PathSize
src/
7 lines
1 line
5 lines

Diff 33617

View Options

src/net_processing.cpp

Loading...
View Options

src/txorphanage.h

Loading...
View Options

src/txorphanage.cpp

Loading...