Page MenuHomePhabricator

txorphanage: Move functions and data into class
ClosedPublic

Authored by PiRK on May 18 2022, 15:03.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC48a4a4c73040: txorphanage: Move functions and data into class
Summary

Collects all the orphan handling globals into a single member var in
net_processing, and ensures access is encapuslated into the interface
functions. Also adds doxygen comments for methods.

This is a backport of core#21148 [11/14]
https://github.com/bitcoin/bitcoin/pull/21148/commits/6bd4963c069bfd0af420e8a3fb724c3b693a1e76

Depends on D11489

Test Plan

With clang and debug:
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.May 18 2022, 15:03
Fabien requested changes to this revision.May 19 2022, 08:52
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/txorphanage.h
23 ↗(On Diff #33602)

no wtxid

This revision now requires changes to proceed.May 19 2022, 08:52

Remove comment about wtxid (relevant to Core's GenTxId class)

Move m_orphanage after nPeersWithValidatedDownloads in PeerManagerImpl

This revision is now accepted and ready to land.May 19 2022, 09:08