Page MenuHomePhabricator
Differential D11490

txorphanage: Move functions and data into class
ClosedPublic
Actions

Authored by PiRK on May 18 2022, 15:03.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC48a4a4c73040: txorphanage: Move functions and data into class
Summary

Collects all the orphan handling globals into a single member var in
net_processing, and ensures access is encapuslated into the interface
functions. Also adds doxygen comments for methods.

This is a backport of core#21148 [11/14]
https://github.com/bitcoin/bitcoin/pull/21148/commits/6bd4963c069bfd0af420e8a3fb724c3b693a1e76

Depends on D11489

Test Plan

With clang and debug:
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 18 2022, 15:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2022, 15:03
PiRK requested review of this revision.May 18 2022, 15:03
teamcity edited the summary of this revision. (Show Details)May 18 2022, 15:03
Harbormaster completed remote builds in B19082: Diff 33584.May 18 2022, 15:26
PiRK updated this revision to Diff 33602.May 19 2022, 08:00

rebase

Harbormaster completed remote builds in B19099: Diff 33602.May 19 2022, 08:37
Fabien requested changes to this revision.May 19 2022, 08:52
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/txorphanage.h
23 ↗(On Diff #33602)

no wtxid

This revision now requires changes to proceed.May 19 2022, 08:52
PiRK updated this revision to Diff 33606.May 19 2022, 09:05

Remove comment about wtxid (relevant to Core's GenTxId class)

Move m_orphanage after nPeersWithValidatedDownloads in PeerManagerImpl

PiRK mentioned this in D11492: net_processing: move AddToCompactExtraTransactions into PeerManagerImpl.May 19 2022, 09:07
Fabien accepted this revision.May 19 2022, 09:08
This revision is now accepted and ready to land.May 19 2022, 09:08
Harbormaster completed remote builds in B19103: Diff 33606.May 19 2022, 09:16
Closed by commit rABC48a4a4c73040: txorphanage: Move functions and data into class (authored by Anthony Towns <aj@erisian.com.au>, committed by PiRK). · Explain WhyMay 19 2022, 16:07
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC48a4a4c73040: txorphanage: Move functions and data into class.

Revision Contents
Changeset List

PathSize
src/
45 lines
test/
50 lines
113 lines
36 lines
test/
functional/
2 lines

Diff 33622

View Options

src/net_processing.cpp

Loading...
View Options

src/test/denialofservice_tests.cpp

Loading...
View Options

src/txorphanage.h

Loading...
View Options

src/txorphanage.cpp

Loading...
View Options

test/functional/p2p_invalid_tx.py

Loading...