net_processing: move AddToCompactExtraTransactions into PeerManagerImpl
ClosedPublic
Actions

Authored by PiRK on May 18 2022, 15:23.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC8b798a60c825: net_processing: move AddToCompactExtraTransactions into PeerManagerImpl

Summary

Allows making vExtraTxnForCompact and vExtraTxnForCompactIt member vars
instead of globals.

This is a backport of core#21148 [13/14]
https://github.com/bitcoin/bitcoin/pull/21148/commits/eeeafb324ef6057f40b5c5fdd8464110e809b0f7

Depends on D11491

Test Plan

With clang and debug:
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 18 2022, 15:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2022, 15:23

PiRK requested review of this revision.May 18 2022, 15:23

teamcity edited the summary of this revision. (Show Details)May 18 2022, 15:23

PiRK added a child revision: D11493: txorphanage: comment improvements.May 18 2022, 15:28

Harbormaster completed remote builds in B19084: Diff 33586.May 18 2022, 15:40

sdulfari accepted this revision.May 18 2022, 20:05

This revision is now accepted and ready to land.May 18 2022, 20:05

rebase

Harbormaster completed remote builds in B19101: Diff 33604.May 19 2022, 08:49

rebase after move nPeersWithValidatedDownloads before m_orphanage in D11490:

Harbormaster completed remote builds in B19104: Diff 33607.May 19 2022, 09:23

Closed by commit rABC8b798a60c825: net_processing: move AddToCompactExtraTransactions into PeerManagerImpl (authored by Anthony Towns <aj@erisian.com.au>, committed by PiRK). · Explain WhyMay 19 2022, 16:07

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC8b798a60c825: net_processing: move AddToCompactExtraTransactions into PeerManagerImpl.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

29 lines

Diff 33625

View Options

net_processing: move AddToCompactExtraTransactions into PeerManagerImplClosedPublicActions