Page MenuHomePhabricator

rpc: Prevent `dumpwallet` from overwriting files
ClosedPublic

Authored by deadalnix on Mar 5 2018, 14:27.

Details

Summary

Prevent arbitrary files from being overwritten. There have been reports
that users have overwritten wallet files this way. It may also avoid
other security issues.

Fixes #9934. Adds mention to release notes and adds a test.

Backport core's PR9937

Depends on D1165

Test Plan
make check
./test/functional/test_runner.py wallet-dump

Diff Detail

Repository
rABC Bitcoin ABC
Branch
dumpwallettest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1991
Build 2131: Bitcoin ABC Buildbot (legacy)
Build 2130: arc lint + arc unit

Event Timeline

Fix the wallet_tests unit test

This revision is now accepted and ready to land.Mar 5 2018, 20:24
This revision was automatically updated to reflect the committed changes.