Page MenuHomePhabricator

[avalanche] Skip processing compact proofs with no shortid
ClosedPublic

Authored by Fabien on Jun 28 2022, 18:54.

Details

Summary

A compact proofs message (avaproofs) with an empty shortid list is actually processed, accounted as a valid message and an empty request is sent in response. We can simplify this logic by skipping all this if there is nothing to process, not sending the empty request and not counting the message as a valid one. As a consequence this also improves the compact proof node counter logic (we are sure we received a useful compact proofs message vs any compact proofs message).

Depends on D11680.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_dont_account_avaproofs_no_shortid
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19500
Build 38730: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 38729: arc lint + arc unit