Page MenuHomePhabricator

Revert "[Cashtab] Route to onboarding if no wallet present"
ClosedPublic

Authored by bytesofman on Jul 13 2022, 22:32.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC90e133bc3358: Revert "[Cashtab] Route to onboarding if no wallet present"
Summary

This reverts commit 5aea9cadfd904617f466f009b3ffcadab7856ab4.

Getting into some upgrades for cashtab-components. I overlooked that the approach taken in D11572 prevents using URLs from outside Cashtab from reaching any screens other than the home page, as wallet is always false when the app first loads.

Need to put some more thought into how this is handled. For now, this current bug is worse than the edge case of "user may be confused if they navigate to the Configure page before creating a wallet," so needs to be reverted.

Test Plan

npm run extension and enable your local extension
Navigate to components.cashtab.com and click the "Cashtab Pay" button on a Cashtab Badge component.
Extension should open with the correct transaction populated

Diff Detail

Repository
rABC Bitcoin ABC
Branch
revert-D11572
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19636
Build 38991: Build Diffcashtab-tests
Build 38990: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jul 14 2022, 00:16
This revision was landed with ongoing or failed builds.Jul 19 2022, 21:23
This revision was automatically updated to reflect the committed changes.