Page MenuHomePhabricator
Differential D11764

only load unbroadcast tx if it exists in loaded mempool
ClosedPublic
Actions

Authored by PiRK on Jul 19 2022, 12:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa1109e55df5f: only load unbroadcast tx if it exists in loaded mempool
Summary

The unbroadcast_txids set only contains the txid. If for some reason a tx gets rejected when loading the mempool from the database, there is no point in loading the corresponding txid in the unbroadcast set, as we don't have the tx any longer for broadcasting.

This is a partial backport of core#18044 and core#19879
https://github.com/bitcoin/bitcoin/pull/18044/commits/c7eb6b4f1fe5bd76388a023529977674534334a7
https://github.com/bitcoin/bitcoin/pull/19879/commits/cb79b9dbf4cd06e17c8c65b36bf15c3ea2641de4

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 19 2022, 12:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 19 2022, 12:52
PiRK requested review of this revision.Jul 19 2022, 12:52
teamcity edited the summary of this revision. (Show Details)Jul 19 2022, 12:52
PiRK updated this revision to Diff 34410.Jul 19 2022, 13:04

include relevant minor changes from core#19879: comment improvements and don't use an unnecessary intermediate variable added_tx

PiRK edited the summary of this revision. (Show Details)Jul 19 2022, 13:05
PiRK updated this revision to Diff 34411.Jul 19 2022, 13:07
PiRK edited the summary of this revision. (Show Details)

remove blank line

Harbormaster completed remote builds in B19657: Diff 34409.Jul 19 2022, 13:08
PiRK added a child revision: D11765: [mempool] Remove unnecessary try-block.Jul 19 2022, 13:10
Harbormaster completed remote builds in B19658: Diff 34410.Jul 19 2022, 13:20
Harbormaster completed remote builds in B19659: Diff 34411.Jul 19 2022, 13:27
Fabien accepted this revision.Jul 19 2022, 14:24
This revision is now accepted and ready to land.Jul 19 2022, 14:24
Closed by commit rABCa1109e55df5f: only load unbroadcast tx if it exists in loaded mempool (authored by PiRK). · Explain WhyJul 20 2022, 06:53
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa1109e55df5f: only load unbroadcast tx if it exists in loaded mempool.

Revision Contents
Changeset List

PathSize
src/
3 lines
13 lines

Diff 34429

View Options

src/txmempool.h

Loading...
View Options

src/validation.cpp

Loading...