Differential D11838

Revert "[avalanche] Ban peers that send conflicting proofs repeatidly"
ClosedPublic
Actions

Authored by Fabien on Aug 10 2022, 16:26.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCc3895d0e0f91: Revert "[avalanche] Ban peers that send conflicting proofs repeatidly"

Summary

This reverts commit 25b171bd59e1e5bcb1c2ea524c1547d0c5880e64.

The ban score can be abused by sending conflicting proofs to different peers repeatidly, getting them to be relayed and get their ban score increased.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 10 2022, 16:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 10 2022, 16:26

Fabien requested review of this revision.Aug 10 2022, 16:26

sdulfari accepted this revision.Aug 10 2022, 16:34

This revision is now accepted and ready to land.Aug 10 2022, 16:34

This revision was landed with ongoing or failed builds.Aug 10 2022, 16:37

Closed by commit rABCc3895d0e0f91: Revert "[avalanche] Ban peers that send conflicting proofs repeatidly" (authored by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc3895d0e0f91: Revert "[avalanche] Ban peers that send conflicting proofs repeatidly".

Harbormaster completed remote builds in B19793: Diff 34615.Aug 10 2022, 16:42

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

9 lines

test/

functional/

abc_p2p_avalanche_proof_voting.py

46 lines

Diff 34616

View Options

src/net_processing.cpp