Differential D11914

[avalanche] Deprecate the legacy proof format
ClosedPublic
Actions

Authored by Fabien on Sep 5 2022, 14:20.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC043402c7c943: [avalanche] Deprecate the legacy proof format

Summary

We don't want to keep 2 format versions forever, so let's deprecate the old format.

Depends on D11913.

Test Plan

ninja all check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_functional_test_no_legacy

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19928
Build 39562: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 39561: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 5 2022, 14:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2022, 14:20

Fabien requested review of this revision.Sep 5 2022, 14:20

Harbormaster completed remote builds in B19928: Diff 34817.Sep 5 2022, 14:36

PiRK accepted this revision.Sep 6 2022, 08:50

This revision is now accepted and ready to land.Sep 6 2022, 08:50

PiRK added a child revision: D11916: [avalanche] remove StakeSigner class.Sep 6 2022, 10:50

Closed by commit rABC043402c7c943: [avalanche] Deprecate the legacy proof format (authored by Fabien). · Explain WhySep 8 2022, 08:10

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC043402c7c943: [avalanche] Deprecate the legacy proof format.

PiRK mentioned this in D16203: add missing includes and remove unneeded ones.May 22 2024, 15:03

PiRK mentioned this in rABC4c05a04a597e: add missing includes and remove unneeded ones.May 23 2024, 07:58

Revision Contents
Changeset List

Path

Size

src/

avalanche/

proof.h

18 lines

proof.cpp

45 lines

proofbuilder.cpp

5 lines

test/

init_tests.cpp

5 lines

peermanager_tests.cpp

7 lines

274 lines

4 lines

54 lines

8 lines

rpc/

avalanche.cpp

34 lines

test/

functional/

abc_rpc_avalancheproof.py

194 lines

abc_rpc_buildavalancheproof.py

15 lines

abc_rpc_ecash.py

17 lines

abc_rpc_getavalancheinfo.py

39 lines

test_framework/

8 lines

105 lines

9 lines

16 lines

Diff 34817

View Options

src/avalanche/proof.h

View Options

src/avalanche/proof.cpp

View Options

src/avalanche/proofbuilder.cpp

View Options

src/avalanche/test/init_tests.cpp

View Options

src/avalanche/test/peermanager_tests.cpp

View Options

src/avalanche/test/proof_tests.cpp

View Options

src/avalanche/test/util.h

View Options

src/avalanche/test/util.cpp

View Options

src/init.cpp

View Options

src/rpc/avalanche.cpp

View Options

test/functional/abc_rpc_avalancheproof.py

View Options

test/functional/abc_rpc_buildavalancheproof.py

View Options

test/functional/abc_rpc_ecash.py

View Options

test/functional/abc_rpc_getavalancheinfo.py

View Options

test/functional/test_framework/avatools.py

View Options

test/functional/test_framework/messages.py

View Options

test/functional/test_framework/test_framework.py

View Options

test/functional/test_runner.py

[avalanche] Deprecate the legacy proof formatClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34817

src/avalanche/proof.h

src/avalanche/proof.cpp

src/avalanche/proofbuilder.cpp

src/avalanche/test/init_tests.cpp

src/avalanche/test/peermanager_tests.cpp

src/avalanche/test/proof_tests.cpp

src/avalanche/test/util.h

src/avalanche/test/util.cpp

src/init.cpp

src/rpc/avalanche.cpp

test/functional/abc_rpc_avalancheproof.py

test/functional/abc_rpc_buildavalancheproof.py

test/functional/abc_rpc_ecash.py

test/functional/abc_rpc_getavalancheinfo.py

test/functional/test_framework/avatools.py

test/functional/test_framework/messages.py

test/functional/test_framework/test_framework.py

test/functional/test_runner.py

[avalanche] Deprecate the legacy proof format
ClosedPublic
Actions

Revision Contents
Changeset List