Differential D11915

[avalanche] Deprecate the enablepeerdiscovery flag
ClosedPublic
Actions

Authored by Fabien on Sep 5 2022, 18:02.

Details

Reviewers

PiRK
sdulfari

Group Reviewers

Restricted Project

Commits

rABC3e8cb35f44bb: [avalanche] Deprecate the enablepeerdiscovery flag

Summary

Make it the default behavior, all tests are compatible already.

Test Plan

ninja all check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 5 2022, 18:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2022, 18:02

Fabien requested review of this revision.Sep 5 2022, 18:02

Harbormaster completed remote builds in B19929: Diff 34818.Sep 5 2022, 18:15

PiRK accepted this revision.Sep 6 2022, 08:18

This revision is now accepted and ready to land.Sep 6 2022, 08:18

Fabien added a child revision: D11921: [avalanche] Deprecate the -enableavalancheproofreplacement flag.Sep 6 2022, 14:07

sdulfari accepted this revision.Sep 6 2022, 16:19

Closed by commit rABC3e8cb35f44bb: [avalanche] Deprecate the enablepeerdiscovery flag (authored by Fabien). · Explain WhySep 7 2022, 09:42

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3e8cb35f44bb: [avalanche] Deprecate the enablepeerdiscovery flag.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

avalanche.h

5 lines

test/

init_tests.cpp

6 lines

init.cpp

5 lines

net_processing.cpp

13 lines

test/

functional/

abc_feature_proof_cleanup.py

1 line

abc_p2p_avalanche_peer_discovery.py

3 lines

abc_p2p_avalanche_quorum.py

1 line

abc_p2p_compactproofs.py

1 line

abc_p2p_getavaaddr.py

1 line

abc_rpc_getavalancheinfo.py

1 line

Diff 34842

View Options

src/avalanche/avalanche.h

View Options

src/avalanche/test/init_tests.cpp

View Options

src/init.cpp

View Options

src/net_processing.cpp

View Options

test/functional/abc_feature_proof_cleanup.py

View Options

test/functional/abc_p2p_avalanche_peer_discovery.py

View Options

test/functional/abc_p2p_avalanche_quorum.py

View Options

test/functional/abc_p2p_compactproofs.py

View Options

test/functional/abc_p2p_getavaaddr.py

View Options

test/functional/abc_rpc_getavalancheinfo.py

[avalanche] Deprecate the enablepeerdiscovery flagClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34842

src/avalanche/avalanche.h

src/avalanche/test/init_tests.cpp

src/init.cpp

src/net_processing.cpp

test/functional/abc_feature_proof_cleanup.py

test/functional/abc_p2p_avalanche_peer_discovery.py

test/functional/abc_p2p_avalanche_quorum.py

test/functional/abc_p2p_compactproofs.py

test/functional/abc_p2p_getavaaddr.py

test/functional/abc_rpc_getavalancheinfo.py

[avalanche] Deprecate the enablepeerdiscovery flag
ClosedPublic
Actions

Revision Contents
Changeset List