Make `m_cached_blocks_path` mutable. Make `ArgsManager::GetBlocksDirPath()` const.
ClosedPublic
Actions

Authored by PiRK on Sep 12 2022, 08:56.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc7edb5c0956f: Make `m_cached_blocks_path` mutable. Make `ArgsManager::GetBlocksDirPath()`…

Summary

This is a backport of core#21850 [1/6]
https://github.com/bitcoin/bitcoin/pull/21850/commits/716de29dd8672d28bfe0a08424e9958fe61054d2

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19988
Build 39667: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 39666: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 12 2022, 08:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2022, 08:56

PiRK requested review of this revision.Sep 12 2022, 08:56

teamcity edited the summary of this revision. (Show Details)Sep 12 2022, 08:56

PiRK added a child revision: D11953: Add `ArgsManager.GetDataDirBase()` and `ArgsManager.GetDataDirNet()` as an intended replacement for `ArgsManager.GetDataDirPath(net_identifier)`.Sep 12 2022, 08:57

Harbormaster completed remote builds in B19988: Diff 34910.Sep 12 2022, 09:19

Fabien accepted this revision.Sep 12 2022, 13:35

This revision is now accepted and ready to land.Sep 12 2022, 13:35

Closed by commit rABCc7edb5c0956f: Make `m_cached_blocks_path` mutable. Make `ArgsManager::GetBlocksDirPath()`… (authored by Kiminuo <kiminuo@protonmail.com>, committed by PiRK). · Explain WhySep 12 2022, 15:17

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc7edb5c0956f: Make `m_cached_blocks_path` mutable. Make `ArgsManager::GetBlocksDirPath()`….

Revision Contents
Changeset List

Path

Size

src/

util/

system.h

4 lines

system.cpp

2 lines

Diff 34910

View Options

src/util/system.h