Paths

Table of Contentst

Differential D11955

Make ArgsManager.GetDataDirPath private and drop needless suffix
ClosedPublic
Actions

Authored by PiRK on Sep 12 2022, 09:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC237effb85acb: Make ArgsManager.GetDataDirPath private and drop needless suffix

Summary

This is a backport of core#21850 [4/6]
https://github.com/bitcoin/bitcoin/pull/21850/commits/13bd8bb0536f008118b1de921654925ed9ce1da7

Depends on D11954

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19991
Build 39673: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 39672: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 12 2022, 09:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2022, 09:01

PiRK requested review of this revision.Sep 12 2022, 09:01

teamcity edited the summary of this revision. (Show Details)Sep 12 2022, 09:01

PiRK added a child revision: D11956: scripted-diff: Replace GetDataDir() calls with `gArgs.GetDataDirNet()` calls.Sep 12 2022, 09:04

Harbormaster completed remote builds in B19991: Diff 34913.Sep 12 2022, 09:57

Fabien accepted this revision.Sep 12 2022, 13:44

This revision is now accepted and ready to land.Sep 12 2022, 13:44

Closed by commit rABC237effb85acb: Make ArgsManager.GetDataDirPath private and drop needless suffix (authored by Kiminuo <kiminuo@protonmail.com>, committed by PiRK). · Explain WhySep 12 2022, 15:17

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC237effb85acb: Make ArgsManager.GetDataDirPath private and drop needless suffix.

Revision Contents
Changeset List

Path

Size

src/

util/

system.h

24 lines

system.cpp

2 lines

Diff 34913

View Options

src/util/system.h