Page MenuHomePhabricator
Differential D12051

[Cashtab] [chronik tx history p2] Add a function to combine chronik tx history for all addresses into a single array
ClosedPublic
Actions

Authored by bytesofman on Sep 23 2022, 18:18.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC594b1d1ac3e0: [Cashtab] [chronik tx history p2] Add a function to combine chronik tx history…
Summary

T2447

Depends on D12048

Add a function to combine the API output of chronik.script.history called on all addresses into a single array

Test Plan

Review the unit test, mocks
npm test

npm start
Observe in dev console that chronikTxHistory as flattened array includes all the tx entries from txHistoryOfAllAddresses

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Sep 23 2022, 18:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2022, 18:18
bytesofman requested review of this revision.Sep 23 2022, 18:18
bytesofman updated this revision to Diff 35167.Sep 23 2022, 18:20

Removed now obsolete fields from mocks

Harbormaster completed remote builds in B20161: Diff 35165.Sep 23 2022, 18:21
Harbormaster completed remote builds in B20163: Diff 35167.Sep 23 2022, 18:24
bytesofman added a child revision: D12052: [Cashtab] [chronik tx history p3] Add a function to sort chronik tx history of all addresses by blockheight and timeFirstSeen.Sep 23 2022, 18:35
bytesofman updated this revision to Diff 35169.Sep 23 2022, 18:41

flattened array length should match that set in parameters

Harbormaster completed remote builds in B20165: Diff 35169.Sep 23 2022, 18:44
bytesofman updated this revision to Diff 35170.Sep 23 2022, 19:03

Actually, you can't trim it here. Need to sort it first.

Harbormaster completed remote builds in B20166: Diff 35170.Sep 23 2022, 19:05
emack accepted this revision.Sep 24 2022, 15:11
This revision is now accepted and ready to land.Sep 24 2022, 15:11
bytesofman updated this revision to Diff 35374.Oct 3 2022, 23:48

rebase

Harbormaster completed remote builds in B20307: Diff 35374.Oct 3 2022, 23:51
Closed by commit rABC594b1d1ac3e0: [Cashtab] [chronik tx history p2] Add a function to combine chronik tx history… (authored by bytesofman). · Explain WhyOct 6 2022, 13:49
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC594b1d1ac3e0: [Cashtab] [chronik tx history p2] Add a function to combine chronik tx history….

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
5 lines
utils/
__mocks__/
2149 lines
__tests__/
11 lines
20 lines

Diff 35475

View Options

web/cashtab/src/hooks/useWallet.js

Loading...
View Options

web/cashtab/src/utils/__mocks__/chronikTxHistory.js

Loading...
View Options

web/cashtab/src/utils/__tests__/chronik.test.js

Loading...
View Options

web/cashtab/src/utils/chronik.js

Loading...