Page MenuHomePhabricator
Differential D12129

[Cashtab] [chronik tx history p9] Correctly calculate etoken amount for genesis txs
ClosedPublic
Actions

Authored by bytesofman on Oct 3 2022, 21:56.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC51d06c116735: [Cashtab] [chronik tx history p9] Correctly calculate etoken amount for genesis…
Summary

T2447

Depends on D12089

Correctly calculate minted amount for eToken genesis txs

Note: still need to correct these amounts for etoken decimals, will happen in another part of this stack

Test Plan

Review unit test and npm test
Mint an eToken and confirm the eTokenAmount field is correct (although it is not adjusted for decimal places)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Oct 3 2022, 21:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2022, 21:56
bytesofman requested review of this revision.Oct 3 2022, 21:56
Harbormaster completed remote builds in B20303: Diff 35370.Oct 3 2022, 21:57
teamcity added a comment.Oct 3 2022, 21:57
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman added a child revision: D12130: [Cashtab] [chronik tx history p10] Parse etokenAmount for token decimals.Oct 3 2022, 23:01
bytesofman updated this revision to Diff 35381.Oct 3 2022, 23:50

rebase

Harbormaster completed remote builds in B20314: Diff 35381.Oct 3 2022, 23:51
teamcity added a comment.Oct 3 2022, 23:51
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
emack accepted this revision.Oct 5 2022, 04:17
This revision is now accepted and ready to land.Oct 5 2022, 04:17
Closed by commit rABC51d06c116735: [Cashtab] [chronik tx history p9] Correctly calculate etoken amount for genesis… (authored by bytesofman). · Explain WhyOct 6 2022, 13:49
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC51d06c116735: [Cashtab] [chronik tx history p9] Correctly calculate etoken amount for genesis….

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
1 line
utils/
__mocks__/
104 lines
__tests__/
41 lines
18 lines

Diff 35482

View Options

web/cashtab/src/hooks/useWallet.js

Loading...
View Options

web/cashtab/src/utils/__mocks__/chronikTxHistory.js

Loading...
View Options

web/cashtab/src/utils/__tests__/chronik.test.js

Loading...
View Options

web/cashtab/src/utils/chronik.js

Loading...