Page MenuHomePhabricator
Differential D12089

[Cashtab] [chronik tx history p8] Add replyAddress to legacy object
ClosedPublic
Actions

Authored by bytesofman on Sep 28 2022, 23:38.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCde84a09dbd9a: [Cashtab] [chronik tx history p8] Add replyAddress to legacy object
Summary

T2447

Depends on D12066

Add replyAddress to parseChronikTx legacy output object

Test Plan

npm start
Send and receive some txs and check the replyAddress field
Review unit tests
npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Sep 28 2022, 23:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2022, 23:38
bytesofman requested review of this revision.Sep 28 2022, 23:38
Harbormaster completed remote builds in B20232: Diff 35271.Sep 28 2022, 23:41
emack added a subscriber: emack.Sep 29 2022, 00:54

can you rebase the stack and then I'll try patching this again

image.png (397×747 px, 61 KB)

bytesofman added a child revision: D12129: [Cashtab] [chronik tx history p9] Correctly calculate etoken amount for genesis txs.Oct 3 2022, 21:56
bytesofman updated this revision to Diff 35380.Oct 3 2022, 23:50

rebase

teamcity added a comment.Oct 3 2022, 23:50
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Harbormaster completed remote builds in B20313: Diff 35380.Oct 3 2022, 23:50
bytesofman added a comment.Oct 3 2022, 23:51

stack is rebased

bytesofman edited the summary of this revision. (Show Details)Oct 4 2022, 14:06
bytesofman added a parent revision: D12066: [Cashtab] [chronik tx history p7] duplicate most legacy tx data.
emack accepted this revision.Oct 5 2022, 03:51
This revision is now accepted and ready to land.Oct 5 2022, 03:51
Closed by commit rABCde84a09dbd9a: [Cashtab] [chronik tx history p8] Add replyAddress to legacy object (authored by bytesofman). · Explain WhyOct 6 2022, 13:49
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCde84a09dbd9a: [Cashtab] [chronik tx history p8] Add replyAddress to legacy object.
PiRK mentioned this in D12198: refactor: remove more unused config argument.Oct 11 2022, 09:57

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
6 lines
utils/
__tests__/
47 lines
18 lines

Diff 35480

View Options

web/cashtab/src/hooks/useWallet.js

Loading...
View Options

web/cashtab/src/utils/__tests__/chronik.test.js

Loading...
View Options

web/cashtab/src/utils/chronik.js

Loading...