Page MenuHomePhabricator
Differential D12072

net: Keep trying to use UPnP when -upnp=1
ClosedPublic
Actions

Authored by PiRK on Sep 27 2022, 12:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5515ad25698e: net: Keep trying to use UPnP when -upnp=1
Summary

This is a backport of core#18077 [3/13]
https://github.com/bitcoin/bitcoin/pull/18077/commits/8b50d1b5bb29b7d1ea0245ba75a8df3144e312dc

Depends on D12070

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 27 2022, 12:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2022, 12:59
PiRK requested review of this revision.Sep 27 2022, 12:59
teamcity edited the summary of this revision. (Show Details)Sep 27 2022, 12:59
PiRK added a child revision: D12071: net: Add flags for port mapping protocols.Sep 27 2022, 12:59
Harbormaster completed remote builds in B20197: Diff 35211.Sep 27 2022, 13:07
teamcity added a comment.Sep 27 2022, 13:07
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[342/520] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[343/520] Linking C static library src/secp256k1/libsecp256k1.a
[344/520] Linking CXX static library src/libbitcoinconsensus.a
[345/520] Linking C executable src/secp256k1/sign-bench
[346/520] Linking C executable src/secp256k1/verify-bench
[347/520] Linking C executable src/secp256k1/recover-bench
[348/520] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[349/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[350/520] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[351/520] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[352/520] Linking C executable src/secp256k1/ecmult-bench
[353/520] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[354/520] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[355/520] Linking C executable src/secp256k1/internal-bench
[356/520] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[357/520] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[358/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[359/520] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[360/520] Linking CXX static library src/libscript.a
[361/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[362/520] Linking CXX static library src/libcommon.a
[363/520] Linking CXX shared library src/libbitcoinconsensus.so.0.26.3
[364/520] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[365/520] Linking CXX executable src/bitcoin-cli
[366/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[367/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[368/520] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[369/520] Linking CXX executable src/bitcoin-tx
[370/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[371/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[372/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[373/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[374/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[375/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[376/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[377/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[378/520] Linking CXX static library src/zmq/libzmq.a
[379/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[380/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[381/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[382/520] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[383/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[384/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[385/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[386/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[387/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[388/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[389/520] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[390/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[391/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[392/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[393/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[394/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[395/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[396/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[397/520] Linking CXX static library src/wallet/libwallet.a
[398/520] Linking CXX static library src/wallet/libwallet-tool.a
[399/520] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
PiRK updated this revision to Diff 35214.Sep 27 2022, 13:09

add missing braces

Fabien accepted this revision.Sep 27 2022, 13:45
This revision is now accepted and ready to land.Sep 27 2022, 13:45
Harbormaster completed remote builds in B20200: Diff 35214.Sep 27 2022, 13:47
Closed by commit rABC5515ad25698e: net: Keep trying to use UPnP when -upnp=1 (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 28 2022, 06:05
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5515ad25698e: net: Keep trying to use UPnP when -upnp=1.

Revision Contents
Changeset List

PathSize
src/
18 lines

Diff 35238

View Options

src/mapport.cpp

Loading...