[Cashtab] Patched nav menu being cut off on some mobile views
ClosedPublic
Actions

Authored by kieran709 on Sep 30 2022, 02:29.

Details

Reviewers

emack
bytesofman

Group Reviewers

Restricted Project

Commits

rABC3a90c9864d57: [Cashtab] Patched nav menu being cut off on some mobile views

Summary

Related to T2703. On some mobile views the nav menu was being cut off on the right edge. NavMenu styling has been changed to set the div right: 0 when in mobile view.

Test Plan

navigate to https://cashtab-dev-test.netlify.app/#/wallet on a mobile device.
open the nav menu and observe that it is fully visible and on the right most edge of the page

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kieran709 created this revision.Sep 30 2022, 02:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2022, 02:29

kieran709 requested review of this revision.Sep 30 2022, 02:29

Harbormaster completed remote builds in B20262: Diff 35312.Sep 30 2022, 02:33

I'll run this through my physical devices later tonight

whilst this clipping issue tested all ok for iOS and Android devices, it clips into the right margin on web and extension versions.

web

extension

This revision now requires changes to proceed.Sep 30 2022, 14:05

To address clipping in web app and extension, navmenu width has been reduced, 1px margin right has been added for web view & extension. Media query removes margin right on mobile view.

Harbormaster completed remote builds in B20272: Diff 35325.Sep 30 2022, 15:53

emack accepted this revision.Sep 30 2022, 23:56

This revision is now accepted and ready to land.Sep 30 2022, 23:56

bytesofman accepted this revision.Oct 1 2022, 15:03

Closed by commit rABC3a90c9864d57: [Cashtab] Patched nav menu being cut off on some mobile views (authored by kieran709). · Explain WhyOct 3 2022, 14:57

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABC3a90c9864d57: [Cashtab] Patched nav menu being cut off on some mobile views.