Page MenuHomePhabricator

[Cashtab] Patched nav menu being cut off on some mobile views
ClosedPublic

Authored by kieran709 on Sep 30 2022, 02:29.

Details

Summary

Related to T2703. On some mobile views the nav menu was being cut off on the right edge. NavMenu styling has been changed to set the div right: 0 when in mobile view.

Test Plan

navigate to https://cashtab-dev-test.netlify.app/#/wallet on a mobile device.
open the nav menu and observe that it is fully visible and on the right most edge of the page

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch-burger-menu-position-mobile
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20272
Build 40222: Build Diffcashtab-tests
Build 40221: arc lint + arc unit

Event Timeline

I'll run this through my physical devices later tonight

emack requested changes to this revision.Sep 30 2022, 14:05

whilst this clipping issue tested all ok for iOS and Android devices, it clips into the right margin on web and extension versions.

web

image.png (206×302 px, 12 KB)

extension

image.png (648×459 px, 40 KB)

This revision now requires changes to proceed.Sep 30 2022, 14:05

To address clipping in web app and extension, navmenu width has been reduced, 1px margin right has been added for web view & extension. Media query removes margin right on mobile view.

This revision is now accepted and ready to land.Sep 30 2022, 23:56