ATMPArgs only uses the config to access the chain params, which is also available via the chain state.
Remove also the ATMPArgs from ConsensusScriptChecks, as it is an unused argument.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Project
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20496 Build 40664: Build Diff lint-circular-dependencies · build-debug · build-without-wallet · build-diff · build-clang · build-clang-tidy Build 40663: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Tail of the build log:
[351/523] Linking C executable src/secp256k1/sign-bench [352/523] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o [353/523] Linking CXX shared library src/libbitcoinconsensus.so.0.26.4 [354/523] Installing component secp256k1 -- Install configuration: "RelWithDebInfo" -- Install component: "secp256k1" -- Installing: /results/artifacts/lib/libsecp256k1.a -- Installing: /results/artifacts/include/secp256k1.h -- Installing: /results/artifacts/include/secp256k1_preallocated.h -- Installing: /results/artifacts/include/secp256k1_recovery.h -- Installing: /results/artifacts/include/secp256k1_schnorr.h [355/523] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so [356/523] Linking C executable src/secp256k1/ecmult-bench [357/523] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o [358/523] Linking C executable src/secp256k1/internal-bench [359/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o [360/523] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o [361/523] Linking CXX executable src/bitcoin-cli [362/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o [363/523] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o [364/523] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o [365/523] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o [366/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o [367/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o [368/523] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o [369/523] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o [370/523] Linking CXX executable src/bitcoin-tx [371/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o [372/523] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o [373/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o [374/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o [375/523] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o [376/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o [377/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o [378/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o [379/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o [380/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o [381/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o [382/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o [383/523] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o [384/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o [385/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o [386/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o [387/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o [388/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o [389/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o [390/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o [391/523] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o [392/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o [393/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o [394/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o [395/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o [396/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o [397/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o [398/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o [399/523] Linking CXX static library src/wallet/libwallet.a [400/523] Linking CXX static library src/wallet/libwallet-tool.a [401/523] Linking CXX executable src/bitcoin-wallet ninja: build stopped: cannot make progress due to previous errors. Build build-clang failed with exit code 1