Paths

Table of Contentst

Differential D12201

refactor: replace config with chain params in AcceptToMemoryPool arguments
AbandonedPublic
Actions

Authored by PiRK on Oct 11 2022, 09:50.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

AcceptToMemoryPool only uses the Config to access the CChainParams.

Depends on D12200

Test Plan

ninja all check-all bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20435
Build 40542: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-bench · build-clang
Build 40541: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 11 2022, 09:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 11 2022, 09:50

PiRK requested review of this revision.Oct 11 2022, 09:50

PiRK added a child revision: D12202: refactor: remove config argument from removeForReorg and updateMempoolForReorg.

Harbormaster completed remote builds in B20435: Diff 35575.Oct 11 2022, 10:12

Fabien accepted this revision.Oct 11 2022, 14:25

This revision is now accepted and ready to land.Oct 11 2022, 14:25

wait for D12213 then rebase

PiRK removed a child revision: D12202: refactor: remove config argument from removeForReorg and updateMempoolForReorg.Oct 14 2022, 07:19

config was removed entirely from arguments in D12214 after rebasing on core#23437

PiRK removed a parent revision: D12200: refactor: remove config in ATMPArgs.Oct 14 2022, 07:42

Revision Contents
Changeset List

Path

Size

src/

bench/

block_assemble.cpp

5 lines

net_processing.cpp

12 lines

node/

transaction.cpp

9 lines

rpc/

rawtransaction.cpp

3 lines

test/

txvalidation_tests.cpp

5 lines

txvalidationcache_tests.cpp

4 lines

util/

setup_common.cpp

2 lines

validation_block_tests.cpp

2 lines

txmempool.cpp

4 lines

validation.h

8 lines

validation.cpp

26 lines

Diff 35575

View Options

src/bench/block_assemble.cpp

View Options

src/net_processing.cpp

View Options

src/node/transaction.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/txvalidation_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

src/test/util/setup_common.cpp

View Options

src/test/validation_block_tests.cpp

View Options

src/txmempool.cpp

View Options

src/validation.h

View Options

refactor: replace config with chain params in AcceptToMemoryPool argumentsAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35575

src/bench/block_assemble.cpp

src/net_processing.cpp

src/node/transaction.cpp

src/rpc/rawtransaction.cpp

src/test/txvalidation_tests.cpp

src/test/txvalidationcache_tests.cpp

src/test/util/setup_common.cpp

src/test/validation_block_tests.cpp

src/txmempool.cpp

src/validation.h

src/validation.cpp

refactor: replace config with chain params in AcceptToMemoryPool arguments
AbandonedPublic
Actions

Revision Contents
Changeset List