Page MenuHomePhabricator
Differential D12231

refactor: move UpdateTip into CChainState
ClosedPublic
Actions

Authored by Fabien on Oct 12 2022, 19:32.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC5478daeb41c9: refactor: move UpdateTip into CChainState
Summary
Makes sense and saves on arguments.

Completes backport of core#22415:
https://github.com/bitcoin/bitcoin/pull/22415/commits/ceb7b35a39145717e2d9d356fd382bd1f95d2a5a

The last (4th) commit is not relevant as we already have a cleaner solution for UpdateMempoolForReorg (see D1667).

Depends on D12230.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Oct 12 2022, 19:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2022, 19:32
Fabien requested review of this revision.Oct 12 2022, 19:32
teamcity edited the summary of this revision. (Show Details)Oct 12 2022, 19:32
Harbormaster completed remote builds in B20476: Diff 35632.Oct 12 2022, 19:57
PiRK accepted this revision.Oct 13 2022, 07:14
PiRK added a subscriber: PiRK.

nice. This PR was on my dependency list for 23173 and 23437

This revision is now accepted and ready to land.Oct 13 2022, 07:14
Closed by commit rABC5478daeb41c9: refactor: move UpdateTip into CChainState (authored by Fabien). · Explain WhyOct 13 2022, 08:27
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC5478daeb41c9: refactor: move UpdateTip into CChainState.

Revision Contents
Changeset List

PathSize
src/
5 lines
34 lines

Diff 35632

View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...