Page MenuHomePhabricator

Add support for CAT
ClosedPublic

Authored by deadalnix on Mar 30 2018, 12:50.

Details

Reviewers
movrcx
jasonbcox
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Maniphest Tasks
T307: Adds OP_CAT functionality into interpreter.cpp
Commits
rSTAGING73dd62acd765: Add support for CAT
rABC73dd62acd765: Add support for CAT
Summary

Add handling for CAT opcode when the monolith script flag is enabled.

Co-authored-by: Joshua Yabut <yabut.joshua@gmail.com>
Co-authored-by: Marcos Mayorga <mm@mm-studios.com>

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/monolith_opcodes.cpp
455 ↗(On Diff #3340)

Looks like a typo at first glance. How about we use lower camel casing, making these two extraA and extraB?

This revision is now accepted and ready to land.Mar 30 2018, 15:45
src/test/monolith_opcodes.cpp
455 ↗(On Diff #3340)

ok.

This revision was automatically updated to reflect the committed changes.