Page MenuHomePhabricator
Differential D1227

Add support for CAT
ClosedPublic
Actions

Authored by deadalnix on Mar 30 2018, 12:50.

Details

Reviewers
movrcx
jasonbcox
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Maniphest Tasks
T307: Adds OP_CAT functionality into interpreter.cpp
Commits
rSTAGING73dd62acd765: Add support for CAT
rABC73dd62acd765: Add support for CAT
Summary

Add handling for CAT opcode when the monolith script flag is enabled.

Co-authored-by: Joshua Yabut <yabut.joshua@gmail.com>
Co-authored-by: Marcos Mayorga <mm@mm-studios.com>

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
opcodecat
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2204
Build 2552: Bitcoin ABC Buildbot (legacy)
Build 2551: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 30 2018, 12:50
teamcity added a comment.Mar 30 2018, 12:52

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 30 2018, 13:11

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2204: Diff 3338.Mar 30 2018, 13:11
deadalnix updated this revision to Diff 3340.Mar 30 2018, 13:18

Fix test label

teamcity added a comment.Mar 30 2018, 13:22

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 30 2018, 13:39

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2205: Diff 3340.Mar 30 2018, 13:39
jasonbcox accepted this revision.Mar 30 2018, 15:45
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/monolith_opcodes.cpp
455 ↗(On Diff #3340)

Looks like a typo at first glance. How about we use lower camel casing, making these two extraA and extraB?

This revision is now accepted and ready to land.Mar 30 2018, 15:45
deadalnix added inline comments.Mar 30 2018, 16:02
src/test/monolith_opcodes.cpp
455 ↗(On Diff #3340)

ok.

Closed by commit rABC73dd62acd765: Add support for CAT (authored by movrcx, committed by deadalnix). · Explain WhyMar 30 2018, 16:06
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
script/
21 lines
test/
data/
32 lines
114 lines

Diff 3338

View Options

src/script/interpreter.cpp

Loading...
View Options

src/test/data/script_tests.json

Loading...
View Options

src/test/monolith_opcodes.cpp

Loading...