Differential D12271

[tests] Make deterministic addrman use nKey = 1
ClosedPublic
Actions

Authored by Fabien on Oct 17 2022, 10:09.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC470b579bbb4e: [tests] Make deterministic addrman use nKey = 1

Summary

addrman_tests fail when consistency checks are enabled, since the tests set the deterministic test addrman's nKey value to zero, which is an invalid value. Change this so that deterministic addrman's nKey value is set to 1.

This requires updating a few tests that are using magic values derived from nKey being set to 0.

Partial backport of core#20233:
https://github.com/bitcoin/bitcoin/pull/20233/commits/10aac241455a3270462d49b53732477ed97623e7

Depends on D12270.

Test Plan

With DEBUG_ADDRMAN:

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 17 2022, 10:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2022, 10:09

Fabien requested review of this revision.Oct 17 2022, 10:09

teamcity edited the summary of this revision. (Show Details)Oct 17 2022, 10:09

Fabien added a child revision: D12272: [addrman] Make addrman consistency checks a runtime option.Oct 17 2022, 10:10

Harbormaster completed remote builds in B20544: Diff 35743.Oct 17 2022, 10:57

PiRK accepted this revision.Oct 17 2022, 13:01

This revision is now accepted and ready to land.Oct 17 2022, 13:01

Closed by commit rABC470b579bbb4e: [tests] Make deterministic addrman use nKey = 1 (authored by Fabien). · Explain WhyOct 17 2022, 14:30

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC470b579bbb4e: [tests] Make deterministic addrman use nKey = 1.

Revision Contents
Changeset List

Path

Size

src/

2 lines

test/

addrman_tests.cpp

101 lines

Diff 35750

src/addrman.h

Loading...

src/test/addrman_tests.cpp

Loading...