Differential D12270

Add missing const to CAddrMan::Check_()
ClosedPublic
Actions

Authored by Fabien on Oct 17 2022, 10:08.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCffb9f52db916: Add missing const to CAddrMan::Check_()

Summary

Also: Always compile the function signature to avoid similar issues in the future.

Partial backport of core#20233:
https://github.com/bitcoin/bitcoin/pull/20233/commits/ee458d84fc187d69f002ebead6fccc4f4f9c0744

Test Plan

With DEBUG_ADDRMAN:

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 17 2022, 10:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2022, 10:08

Fabien requested review of this revision.Oct 17 2022, 10:08

teamcity edited the summary of this revision. (Show Details)Oct 17 2022, 10:09

Fabien added a child revision: D12271: [tests] Make deterministic addrman use nKey = 1.Oct 17 2022, 10:09

Harbormaster completed remote builds in B20543: Diff 35742.Oct 17 2022, 10:48

PiRK accepted this revision.Oct 17 2022, 12:58

This revision is now accepted and ready to land.Oct 17 2022, 12:58

Closed by commit rABCffb9f52db916: Add missing const to CAddrMan::Check_() (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyOct 17 2022, 14:27

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCffb9f52db916: Add missing const to CAddrMan::Check_().

Revision Contents
Changeset List

Path

Size

src/

4 lines

44 lines

Diff 35749

src/addrman.h

Loading...

src/addrman.cpp

Loading...