Differential D12275

[addrman] Merge the two Add() functions
ClosedPublic
Actions

Authored by Fabien on Oct 17 2022, 13:56.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCc36b96ee5735: [addrman] Merge the two Add() functions

Summary

Merge the two definitions of this overloaded function to reduce code duplication.

Backport of core#22627.

Depends on D12274.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 17 2022, 13:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2022, 13:56

Fabien requested review of this revision.Oct 17 2022, 13:56

teamcity edited the summary of this revision. (Show Details)Oct 17 2022, 13:56

Harbormaster completed remote builds in B20548: Diff 35748.Oct 17 2022, 14:10

PiRK accepted this revision.Oct 17 2022, 15:26

This revision is now accepted and ready to land.Oct 17 2022, 15:26

Closed by commit rABCc36b96ee5735: [addrman] Merge the two Add() functions (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyOct 17 2022, 15:29

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc36b96ee5735: [addrman] Merge the two Add() functions.

Revision Contents
Changeset List

Path

Size

src/

addrman.h

17 lines

rpc/

net.cpp

2 lines

test/

addrman_tests.cpp

84 lines

net_tests.cpp

4 lines

Diff 35765

View Options

src/addrman.h

View Options

src/rpc/net.cpp

View Options

src/test/addrman_tests.cpp

View Options

[addrman] Merge the two Add() functionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35765

src/addrman.h

src/rpc/net.cpp

src/test/addrman_tests.cpp

src/test/net_tests.cpp

[addrman] Merge the two Add() functions
ClosedPublic
Actions

Revision Contents
Changeset List