Paths

Table of Contentst

Differential D12279

chain: add and set ASSUMED_VALID_FLAG for assumeutxo
ClosedPublic
Actions

Authored by PiRK on Oct 17 2022, 15:06.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC84b17a35a312: chain: add and set ASSUMED_VALID_FLAG for assumeutxo

Summary

chain: add and set ASSUMED_VALID_FLAG for assumeutxo

Instead of (ab)using the existing BlockValidity flags to mark CBlockIndex entries which
we haven't yet fully validated (but assume validity for use with UTXO snapshot
loading), introduce a status flag that specifically marks an assumed-valid state.

This state is then removed in RaiseValidity() when the block has actually been
validated.

This distinction will allow us to make the necessary changes to various parts of the
system to facilitate assumeutxo/background chainstate validation but without leaking
details like snapshot height, as we had done previously.

validation: set ASSUMED_VALID_FLAG during snapshot load

Mark the block index entries that are beneath the snapshot base block as
assumed-valid. Subsequent commits will make use of this flag in other
parts of the system.

This is a backport of core#21526 [5 & 6/12]
https://github.com/bitcoin/bitcoin/pull/21526/commits/42b2520db93fd9feb3df4101654391fa7d3e2140
https://github.com/bitcoin/bitcoin/pull/21526/commits/01a9b8fe719efab2c268dc738bc93cfbdf92edb7

Depends on D12278

Test Plan

ninja all check-all bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20578
Build 40826: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40825: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 17 2022, 15:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2022, 15:06

PiRK requested review of this revision.Oct 17 2022, 15:06

teamcity edited the summary of this revision. (Show Details)Oct 17 2022, 15:06

squash with next commit to use the flag immediately

PiRK edited the summary of this revision. (Show Details)Oct 17 2022, 15:12

PiRK added a child revision: D12280: validation: have LoadBlockIndex account for snapshot use.Oct 17 2022, 15:14

Harbormaster completed remote builds in B20552: Diff 35759.Oct 17 2022, 16:00

Harbormaster completed remote builds in B20553: Diff 35760.Oct 17 2022, 16:07

This is missing tests and fuzzing

src/blockindex.h
226 ↗	(On Diff #35760)	And there is no test
src/blockstatus.h
46 ↗	(On Diff #35760)	Missing the end of the comment

This revision now requires changes to proceed.Oct 18 2022, 09:37

add missing comment line, add a unit test for CBlockIndex::IsAssumedValid and CBlockIndex::RaiseValidity

remove unnecessary loop level

Harbormaster completed remote builds in B20578: Diff 35793.Oct 18 2022, 13:38

Harbormaster completed remote builds in B20580: Diff 35795.Oct 18 2022, 13:47

Please complete the chain.cpp fuzzer as well

This revision now requires changes to proceed.Oct 18 2022, 14:05

add fuzzing and run ninja bitcoin-fuzzers

Harbormaster completed remote builds in B20582: Diff 35797.Oct 18 2022, 14:29

Fabien accepted this revision.Oct 18 2022, 15:08

This revision is now accepted and ready to land.Oct 18 2022, 15:08

PiRK added a child revision: D12281: validation: fix CheckBlockIndex for multiple chainstates.Oct 19 2022, 08:12

PiRK removed a child revision: D12280: validation: have LoadBlockIndex account for snapshot use.Oct 19 2022, 08:15

Closed by commit rABC84b17a35a312: chain: add and set ASSUMED_VALID_FLAG for assumeutxo (authored by James O'Beirne <james.obeirne@pm.me>, committed by PiRK). · Explain WhyOct 19 2022, 11:35

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC84b17a35a312: chain: add and set ASSUMED_VALID_FLAG for assumeutxo.

Revision Contents
Changeset List

Path

Size

src/

10 lines

17 lines

test/

blockindex_tests.cpp

49 lines

15 lines

Diff 35793

src/blockindex.h

Loading...

src/blockstatus.h

Loading...

src/test/blockindex_tests.cpp

Loading...

src/validation.cpp

Loading...