Differential D12292

[net] Remove CConnMan::SetAsmap()
ClosedPublic
Actions

Authored by Fabien on Oct 18 2022, 13:06.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCc7787012798d: [net] Remove CConnMan::SetAsmap()

Summary

CAddrMan::m_asmap is now set directly in AppInitMain() so
CConnMan::SetAsmap() is no longer required.

Partial backport of core#22791:
https://github.com/bitcoin/bitcoin/pull/22791/commits/593247872decd6d483a76e96d79433247226ad14

Depends on D12291.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR22791_p2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20576
Build 40822: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40821: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 18 2022, 13:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 18 2022, 13:06

Fabien requested review of this revision.Oct 18 2022, 13:06

teamcity edited the summary of this revision. (Show Details)Oct 18 2022, 13:06

Fabien added a child revision: D12293: [addrman] Set m_asmap in CAddrMan initializer list.Oct 18 2022, 13:06

Harbormaster completed remote builds in B20576: Diff 35791.Oct 18 2022, 13:21

PiRK accepted this revision.Oct 18 2022, 13:42

This revision is now accepted and ready to land.Oct 18 2022, 13:42

Closed by commit rABCc7787012798d: [net] Remove CConnMan::SetAsmap() (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyOct 18 2022, 20:14

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc7787012798d: [net] Remove CConnMan::SetAsmap().

Revision Contents
Changeset List

Path

Size

src/

net.h

4 lines

Diff 35791

View Options

[net] Remove CConnMan::SetAsmap()ClosedPublicActions