Differential D1231

Set Monolith opcode enable script flag if monolith enabled
ClosedPublic
Actions

Authored by deadalnix on Mar 31 2018, 20:24.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Maniphest Tasks

T299: Re-enable Satoshi OpCodes

Commits

rSTAGINGf103591b993f: Set Monolith opcode enable script flag if monolith enabled
rABCf103591b993f: Set Monolith opcode enable script flag if monolith enabled

Summary

Sets the SCRIPT_ENABLE_OPCODE_MONOLITH flag if monolith has been enabled

Co-authored-by: Joshua Yabut <yabut.joshua@gmail.com>
Co-authored-by: Marcos Mayorga <mm@mm-studios.com>
Co-authored-by: Daniel Connolly <daniel@dconnolly.com>

Test Plan

make check

Added an integration test for activation.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Mar 31 2018, 20:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 31 2018, 20:24

deadalnix added parent revisions: D1230: Refactor flag selection in AcceptToMemoryPoolWorker, D1229: Make CheckInputs flags's parameter constant.Mar 31 2018, 20:25

deadalnix mentioned this in D1194: Set Monolith opcode enable script flag if monolith enabled.Mar 31 2018, 20:27

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

jasonbcox added a subscriber: jasonbcox.Mar 31 2018, 20:48

jasonbcox added inline comments.

src/validation.cpp
1582 ↗	(On Diff #3353)	use -> us (I think?)
1586–1587 ↗	(On Diff #3353)	For my understanding: despite this transaction not having monolith opcodes enabled, we're treating it as if it does. Is that correct?