fBlocksOnly has several issues:
The name is confusing
It is untested
Fix both.Backport of core#22955.
Depends on D12437.
Details
Details
- Reviewers
sdulfari - Group Reviewers
Restricted Project - Commits
- rABC1c980ec8dc17: p2p: Rename fBlocksOnly, Add test
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- PR22955
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20855 Build 41367: Build Diff build-debug · lint-circular-dependencies · build-clang · build-clang-tidy · build-diff · build-without-wallet Build 41366: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Failed tests logs:
====== Bitcoin ABC functional tests: rpc_blockchain.py ======
------- Stdout: -------
2022-11-09T21:06:16.141000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_ _20221109_210210/rpc_blockchain_56
2022-11-09T21:06:16.737000Z TestFramework (INFO): Create some old blocks
2022-11-09T21:06:17.997000Z TestFramework (INFO): Test getblockchaininfo
2022-11-09T21:06:19.511000Z TestFramework (INFO): Test getchaintxstats
2022-11-09T21:06:19.535000Z TestFramework (INFO): Test that gettxoutsetinfo() works for blockchain with just the genesis block
2022-11-09T21:06:19.615000Z TestFramework (INFO): Test that gettxoutsetinfo() returns the same result after invalidate/reconsider block
2022-11-09T21:06:19.883000Z TestFramework (INFO): Test hash_type option for gettxoutsetinfo()
2022-11-09T21:06:23.874000Z TestFramework (INFO): Test waitforblockheight
2022-11-09T21:06:24.127000Z TestFramework (INFO): Test that getblock with verbosity 1 doesn't include fee
2022-11-09T21:06:24.128000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/work/test/functional/test_framework/test_framework.py", line 133, in main
self.run_test()
File "/work/test/functional/rpc_blockchain.py", line 74, in run_test
self._test_getblock_txfee()
File "/work/test/functional/rpc_blockchain.py", line 469, in _test_getblock_txfee
assert 'fee' not in block['tx'][1]
AssertionError
2022-11-09T21:06:24.179000Z TestFramework (INFO): Stopping nodes
2022-11-09T21:06:24.481000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_ _20221109_210210/rpc_blockchain_56
2022-11-09T21:06:24.481000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_ _20221109_210210/rpc_blockchain_56/test_framework.log
2022-11-09T21:06:24.481000Z TestFramework (ERROR):
2022-11-09T21:06:24.481000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_ _20221109_210210/rpc_blockchain_56' to consolidate all logs
2022-11-09T21:06:24.481000Z TestFramework (ERROR):
2022-11-09T21:06:24.481000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-11-09T21:06:24.481000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-11-09T21:06:24.481000Z TestFramework (ERROR):Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_blockchain.py