Differential D12458

[Cashtab] [p1 local msg verify] Verify function is not async
ClosedPublic
Actions

Authored by bytesofman on Nov 10 2022, 10:18.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC9f394b935080: [Cashtab] [p1 local msg verify] Verify function is not async

Summary

T2730

Stacked diff to deprecate bchObj.BitcoinCash.verifyMessage

This diff removes the async from the existing function, as bchObj.BitcoinCash.verifyMessage is not an async function. This is a bug fix as preparation for dropping in a replacement function.

Test Plan

npm start
Verify some messages, note no change in existing functionality

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20896
Build 41449: Build Diff	cashtab-tests
Build 41448: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 10 2022, 10:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2022, 10:18

bytesofman requested review of this revision.Nov 10 2022, 10:18

Harbormaster completed remote builds in B20865: Diff 36222.Nov 10 2022, 10:21

bytesofman added a child revision: D12459: [Cashtab] [p2 local msg verify] Add stub local method.Nov 10 2022, 11:38

emack accepted this revision.Nov 10 2022, 13:37

This revision is now accepted and ready to land.Nov 10 2022, 13:37

rebase

Harbormaster completed remote builds in B20896: Diff 36272.Nov 14 2022, 12:16

Closed by commit rABC9f394b935080: [Cashtab] [p1 local msg verify] Verify function is not async (authored by bytesofman). · Explain WhyNov 14 2022, 15:26

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC9f394b935080: [Cashtab] [p1 local msg verify] Verify function is not async.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

SignVerifyMsg/

SignVerifyMsg.js

4 lines

Diff 36272

View Options

web/cashtab/src/components/SignVerifyMsg/SignVerifyMsg.js

[Cashtab] [p1 local msg verify] Verify function is not asyncClosedPublicActions