Paths

Table of Contentst

Differential D12464

[Cashtab] [p7 local msg verify] Install published dependency
ClosedPublic
Actions

Authored by bytesofman on Nov 10 2022, 12:30.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCcf315a7cc3f1: [Cashtab] [p7 local msg verify] Install published dependency

Summary

T2730

Depends on D12463

Publish xecjs-message and install this published version in Cashtab, instead of the local one we have been developing.

Snapshot tests for SignVerifyMsg are reintroduced as they are no longer broken by the locally installed dep.

Test Plan

Same as D12462

Diff Detail

Repository

rABC Bitcoin ABC

Branch

local-msg-signing

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20873
Build 41403: Build Diff	cashtab-tests
Build 41402: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 10 2022, 12:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2022, 12:30

bytesofman requested review of this revision.Nov 10 2022, 12:30

Harbormaster completed remote builds in B20873: Diff 36230.Nov 10 2022, 12:32

bytesofman added a child revision: D12465: [Cashtab] [p8 local msg verify] Deprecate legacy verification function.Nov 10 2022, 12:34

emack accepted this revision.Nov 14 2022, 11:17

This revision is now accepted and ready to land.Nov 14 2022, 11:17

rebase

Harbormaster completed remote builds in B20902: Diff 36278.Nov 14 2022, 12:09

Closed by commit rABCcf315a7cc3f1: [Cashtab] [p7 local msg verify] Install published dependency (authored by bytesofman). · Explain WhyNov 14 2022, 15:26

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCcf315a7cc3f1: [Cashtab] [p7 local msg verify] Install published dependency.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

package-lock.json

32 lines

package.json

2 lines

src/

components/

SignVerifyMsg/

__tests__/

SignVerifyMsg.test.js

97 lines

__snapshots__/

SignVerifyMsg.test.js.snap

xecjs-message/

CHANGELOG.md

12 lines

package.json

2 lines

Diff 36230

View Options

web/cashtab/package-lock.json

View Options

web/cashtab/package.json

View Options

web/cashtab/src/components/SignVerifyMsg/tests/SignVerifyMsg.test.js

View Options

web/cashtab/src/components/SignVerifyMsg/tests/snapshots/SignVerifyMsg.test.js.snap

View Options

web/xecjs-message/CHANGELOG.md

View Options

web/xecjs-message/package.json

[Cashtab] [p7 local msg verify] Install published dependencyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36230

web/cashtab/package-lock.json

web/cashtab/package.json

web/cashtab/src/components/SignVerifyMsg/__tests__/SignVerifyMsg.test.js

web/cashtab/src/components/SignVerifyMsg/__tests__/__snapshots__/SignVerifyMsg.test.js.snap

web/xecjs-message/CHANGELOG.md

web/xecjs-message/package.json

[Cashtab] [p7 local msg verify] Install published dependency
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/components/SignVerifyMsg/tests/SignVerifyMsg.test.js

web/cashtab/src/components/SignVerifyMsg/tests/snapshots/SignVerifyMsg.test.js.snap