Page MenuHomePhabricator

Move pindexBestInvalid and pindexBestParked to ChainstateManager
ClosedPublic

Authored by PiRK on Nov 14 2022, 15:24.

Details

Summary

A private member is better than a global.

This concludes backport of core#23785
https://github.com/bitcoin/bitcoin/pull/23785/commits/fab6d6b2d154893ab422dda87f3535d42c3e06f4

Depends on D12486

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Nov 14 2022, 15:24
PiRK edited the summary of this revision. (Show Details)

don't forget to also reset m_best_parked on ChainstateLanger::Unload()

This revision is now accepted and ready to land.Nov 16 2022, 11:03